1berry/nginx
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SSL: disabled sending shutdown after ngx_http_test_reading().

Browse Source 
Sending shutdown when ngx_http_test_reading() detects the connection is
closed can result in "SSL_shutdown() failed (SSL: ... bad write retry)"
critical log messages if there are blocked writes.

Fix is to avoid sending shutdown via the c->ssl->no_send_shutdown flag,
similarly to how it is done in ngx_http_keepalive_handler() for kqueue
when pending EOF is detected.

Reported by Jan Prachař
(http://mailman.nginx.org/pipermail/nginx-devel/2018-December/011702.html).
This commit is contained in:
Maxim Dounin 2020-08-10 18:52:34 +03:00
parent 1d696cd379
commit eae2b2fdf1
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/http/ngx_http_request.c
View File

@ -2992,6 +2992,12 @@ closed:
rev->error = 1; rev->error = 1;
} }
#if (NGX_HTTP_SSL)
if (c->ssl) {
c->ssl->no_send_shutdown = 1;
}
#endif
ngx_log_error(NGX_LOG_INFO, c->log, err, ngx_log_error(NGX_LOG_INFO, c->log, err,
"client prematurely closed connection"); "client prematurely closed connection");