From 6ba18bc35ee1bdf95130ee653adf451928ae8b74 Mon Sep 17 00:00:00 2001 From: Maxim Dounin Date: Fri, 28 Feb 2020 17:21:18 +0300 Subject: [PATCH] Added default overwrite in error_page 494. We used to have default error_page overwrite for 495, 496, and 497, so a configuration like error_page 495 /error; will result in error 400, much like without any error_page configured. The 494 status code was introduced later (in 3848:de59ad6bf557, nginx 0.9.4), and relevant changes to ngx_http_core_error_page() were missed, resulting in inconsistent behaviour of "error_page 494" - with error_page configured it results in 494 being returned instead of 400. Reported by Frank Liu, http://mailman.nginx.org/pipermail/nginx/2020-February/058957.html. --- src/http/ngx_http_core_module.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/http/ngx_http_core_module.c b/src/http/ngx_http_core_module.c index da23af1fb..4867bed2b 100644 --- a/src/http/ngx_http_core_module.c +++ b/src/http/ngx_http_core_module.c @@ -4687,6 +4687,7 @@ ngx_http_core_error_page(ngx_conf_t *cf, ngx_command_t *cmd, void *conf) case NGX_HTTP_TO_HTTPS: case NGX_HTTPS_CERT_ERROR: case NGX_HTTPS_NO_CERT: + case NGX_HTTP_REQUEST_HEADER_TOO_LARGE: err->overwrite = NGX_HTTP_BAD_REQUEST; } }