1berry/nextcloud-android
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix tests

Browse Source 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
This commit is contained in:
alperozturk 2025-06-10 14:50:03 +02:00
parent 6e5ade0e53
commit 3d2feb283b
No known key found for this signature in database
GPG Key ID: 4E577DC593B59BDF
1 changed files with 44 additions and 69 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

113
app/src/androidTest/java/com/owncloud/android/ui/fragment/FileDetailSharingFragmentIT.kt
View File

@ -49,8 +49,7 @@ import org.hamcrest.CoreMatchers.anyOf
import org.hamcrest.CoreMatchers.`is` import org.hamcrest.CoreMatchers.`is`
import org.hamcrest.CoreMatchers.not import org.hamcrest.CoreMatchers.not
import org.junit.After import org.junit.After
import org.junit.Assert.assertFalse import org.junit.Assert.assertEquals
import org.junit.Assert.assertTrue
import org.junit.Before import org.junit.Before
import org.junit.Rule import org.junit.Rule
import org.junit.Test import org.junit.Test
@ -887,84 +886,60 @@ class FileDetailSharingFragmentIT : AbstractIT() {
@Test @Test
fun testUploadAndEditingSharePermissions() { fun testUploadAndEditingSharePermissions() {
val share = OCShare().apply { val testCases = mapOf(
permissions = MAXIMUM_PERMISSIONS_FOR_FOLDER MAXIMUM_PERMISSIONS_FOR_FOLDER to true,
NO_PERMISSION to false,
READ_PERMISSION_FLAG to false,
CREATE_PERMISSION_FLAG to false,
DELETE_PERMISSION_FLAG to false,
SHARE_PERMISSION_FLAG to false
)
val share = OCShare()
for ((permission, expected) in testCases) {
share.permissions = permission
assertEquals("Failed for permission: $permission", expected, SharePermissionManager.canEdit(share))
} }
assertTrue(SharePermissionManager.canEdit(share))
share.permissions = NO_PERMISSION
assertFalse(SharePermissionManager.canEdit(share))
share.permissions = READ_PERMISSION_FLAG
assertFalse(SharePermissionManager.canEdit(share))
share.permissions = CREATE_PERMISSION_FLAG
assertFalse(SharePermissionManager.canEdit(share))
share.permissions = DELETE_PERMISSION_FLAG
assertFalse(SharePermissionManager.canEdit(share))
share.permissions = SHARE_PERMISSION_FLAG
assertFalse(SharePermissionManager.canEdit(share))
} }
@Test @Test
@Suppress("MagicNumber")
fun testReadOnlySharePermissions() { fun testReadOnlySharePermissions() {
val share = OCShare().apply { val testCases = mapOf(
permissions = 17 READ_PERMISSION_FLAG to true,
NO_PERMISSION to false,
CREATE_PERMISSION_FLAG to false,
DELETE_PERMISSION_FLAG to false,
SHARE_PERMISSION_FLAG to false,
MAXIMUM_PERMISSIONS_FOR_FOLDER to false,
MAXIMUM_PERMISSIONS_FOR_FILE to false
)
val share = OCShare()
for ((permission, expected) in testCases) {
share.permissions = permission
assertEquals("Failed for permission: $permission", expected, SharePermissionManager.isViewOnly(share))
} }
assertTrue(SharePermissionManager.isViewOnly(share))
share.permissions = NO_PERMISSION
assertFalse(SharePermissionManager.isViewOnly(share))
share.permissions = READ_PERMISSION_FLAG
assertTrue(SharePermissionManager.isViewOnly(share))
share.permissions = CREATE_PERMISSION_FLAG
assertFalse(SharePermissionManager.isViewOnly(share))
share.permissions = DELETE_PERMISSION_FLAG
assertFalse(SharePermissionManager.isViewOnly(share))
share.permissions = SHARE_PERMISSION_FLAG
assertFalse(SharePermissionManager.isViewOnly(share))
share.permissions = MAXIMUM_PERMISSIONS_FOR_FOLDER
assertFalse(SharePermissionManager.isViewOnly(share))
share.permissions = MAXIMUM_PERMISSIONS_FOR_FILE
assertFalse(SharePermissionManager.isViewOnly(share))
} }
@Test @Test
@Suppress("MagicNumber") fun testFileRequestSharePermission() {
fun testFileDropSharePermissions() { val testCases = mapOf(
CREATE_PERMISSION_FLAG to true,
NO_PERMISSION to false,
READ_PERMISSION_FLAG to false,
DELETE_PERMISSION_FLAG to false,
SHARE_PERMISSION_FLAG to false,
MAXIMUM_PERMISSIONS_FOR_FOLDER to false,
MAXIMUM_PERMISSIONS_FOR_FILE to false
)
val share = OCShare().apply { val share = OCShare().apply {
permissions = 4 isFolder = true
} }
assertTrue(SharePermissionManager.isFileRequest(share))
share.permissions = NO_PERMISSION for ((permission, expected) in testCases) {
assertFalse(SharePermissionManager.isFileRequest(share)) share.permissions = permission
assertEquals("Failed for permission: $permission", expected, SharePermissionManager.isFileRequest(share))
share.permissions = READ_PERMISSION_FLAG }
assertFalse(SharePermissionManager.isFileRequest(share))
share.permissions = CREATE_PERMISSION_FLAG
assertTrue(SharePermissionManager.isFileRequest(share))
share.permissions = DELETE_PERMISSION_FLAG
assertFalse(SharePermissionManager.isFileRequest(share))
share.permissions = SHARE_PERMISSION_FLAG
assertFalse(SharePermissionManager.isFileRequest(share))
share.permissions = MAXIMUM_PERMISSIONS_FOR_FOLDER
assertFalse(SharePermissionManager.isFileRequest(share))
share.permissions = MAXIMUM_PERMISSIONS_FOR_FILE
assertFalse(SharePermissionManager.isFileRequest(share))
} }
} }