From 1b5dd285e3af2d20e49953a0cc012dc409bb865a Mon Sep 17 00:00:00 2001 From: Daniel Black Date: Tue, 7 Feb 2023 10:08:51 +1100 Subject: [PATCH 1/7] Revert "no 11.0 yet" This reverts commit 7afb96a1aebf191f3d13d4fcf298cf0e4977408e. --- 11.0/Dockerfile | 139 ++++++++++ 11.0/docker-entrypoint.sh | 545 ++++++++++++++++++++++++++++++++++++++ 11.0/healthcheck.sh | 334 +++++++++++++++++++++++ 3 files changed, 1018 insertions(+) create mode 100644 11.0/Dockerfile create mode 100755 11.0/docker-entrypoint.sh create mode 100755 11.0/healthcheck.sh diff --git a/11.0/Dockerfile b/11.0/Dockerfile new file mode 100644 index 0000000..e2a2236 --- /dev/null +++ b/11.0/Dockerfile @@ -0,0 +1,139 @@ +# vim:set ft=dockerfile: +FROM ubuntu:jammy + +# add our user and group first to make sure their IDs get assigned consistently, regardless of whatever dependencies get added +RUN groupadd -r mysql && useradd -r -g mysql mysql + +# add gosu for easy step-down from root +# https://github.com/tianon/gosu/releases +# gosu key is B42F6819007F00F88E364FD4036A9C25BF357DD4 +ENV GOSU_VERSION 1.14 + +ARG GPG_KEYS=177F4010FE56CA3336300305F1656F24C74CD1D8 +# pub rsa4096 2016-03-30 [SC] +# 177F 4010 FE56 CA33 3630 0305 F165 6F24 C74C D1D8 +# uid [ unknown] MariaDB Signing Key +# sub rsa4096 2016-03-30 [E] +# install "libjemalloc2" as it offers better performance in some cases. Use with LD_PRELOAD +# install "pwgen" for randomizing passwords +# install "tzdata" for /usr/share/zoneinfo/ +# install "xz-utils" for .sql.xz docker-entrypoint-initdb.d files +# install "zstd" for .sql.zst docker-entrypoint-initdb.d files +# hadolint ignore=SC2086 +RUN set -eux; \ + apt-get update; \ + DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \ + ca-certificates \ + gpg \ + gpgv \ + libjemalloc2 \ + pwgen \ + tzdata \ + xz-utils \ + zstd ; \ + savedAptMark="$(apt-mark showmanual)"; \ + apt-get install -y --no-install-recommends \ + dirmngr \ + gpg-agent \ + wget; \ + rm -rf /var/lib/apt/lists/*; \ + dpkgArch="$(dpkg --print-architecture | awk -F- '{ print $NF }')"; \ + wget -q -O /usr/local/bin/gosu "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$dpkgArch"; \ + wget -q -O /usr/local/bin/gosu.asc "https://github.com/tianon/gosu/releases/download/$GOSU_VERSION/gosu-$dpkgArch.asc"; \ + GNUPGHOME="$(mktemp -d)"; \ + export GNUPGHOME; \ + gpg --batch --keyserver hkps://keys.openpgp.org --recv-keys B42F6819007F00F88E364FD4036A9C25BF357DD4; \ + for key in $GPG_KEYS; do \ + gpg --batch --keyserver keyserver.ubuntu.com --recv-keys "$key"; \ + done; \ + gpg --batch --export "$GPG_KEYS" > /etc/apt/trusted.gpg.d/mariadb.gpg; \ + if command -v gpgconf >/dev/null; then \ + gpgconf --kill all; \ + fi; \ + gpg --batch --verify /usr/local/bin/gosu.asc /usr/local/bin/gosu; \ + gpgconf --kill all; \ + rm -rf "$GNUPGHOME" /usr/local/bin/gosu.asc; \ + apt-mark auto '.*' > /dev/null; \ + [ -z "$savedAptMark" ] || apt-mark manual $savedAptMark >/dev/null; \ + apt-get purge -y --auto-remove -o APT::AutoRemove::RecommendsImportant=false; \ + chmod +x /usr/local/bin/gosu; \ + gosu --version; \ + gosu nobody true + +RUN mkdir /docker-entrypoint-initdb.d + +# Ensure the container exec commands handle range of utf8 characters based of +# default locales in base image (https://github.com/docker-library/docs/blob/135b79cc8093ab02e55debb61fdb079ab2dbce87/ubuntu/README.md#locales) +ENV LANG C.UTF-8 + +# OCI annotations to image +LABEL org.opencontainers.image.authors="MariaDB Community" \ + org.opencontainers.image.title="MariaDB Database" \ + org.opencontainers.image.description="MariaDB Database for relational SQL" \ + org.opencontainers.image.documentation="https://hub.docker.com/_/mariadb/" \ + org.opencontainers.image.base.name="docker.io/library/ubuntu:jammy" \ + org.opencontainers.image.licenses="GPL-2.0" \ + org.opencontainers.image.source="https://github.com/MariaDB/mariadb-docker" \ + org.opencontainers.image.vendor="MariaDB Community" \ + org.opencontainers.image.version="11.0.0" \ + org.opencontainers.image.url="https://github.com/MariaDB/mariadb-docker" + +# bashbrew-architectures: amd64 arm64v8 ppc64le s390x +ARG MARIADB_VERSION=1:11.0.0+maria~ubu2204 +ENV MARIADB_VERSION $MARIADB_VERSION +# release-status:Alpha +# (https://downloads.mariadb.org/rest-api/mariadb/) + +# Allowing overriding of REPOSITORY, a URL that includes suite and component for testing and Enterprise Versions +ARG REPOSITORY="http://archive.mariadb.org/mariadb-11.0.0/repo/ubuntu/ jammy main" + +RUN set -e;\ + echo "deb ${REPOSITORY}" > /etc/apt/sources.list.d/mariadb.list; \ + { \ + echo 'Package: *'; \ + echo 'Pin: release o=MariaDB'; \ + echo 'Pin-Priority: 999'; \ + } > /etc/apt/preferences.d/mariadb +# add repository pinning to make sure dependencies from this MariaDB repo are preferred over Debian dependencies +# libmariadbclient18 : Depends: libmysqlclient18 (= 5.5.42+maria-1~wheezy) but 5.5.43-0+deb7u1 is to be installed + +# the "/var/lib/mysql" stuff here is because the mysql-server postinst doesn't have an explicit way to disable the mysql_install_db codepath besides having a database already "configured" (ie, stuff in /var/lib/mysql/mysql) +# also, we set debconf keys to make APT a little quieter +# hadolint ignore=DL3015 +RUN set -ex; \ + { \ + echo "mariadb-server" mysql-server/root_password password 'unused'; \ + echo "mariadb-server" mysql-server/root_password_again password 'unused'; \ + } | debconf-set-selections; \ + apt-get update; \ +# mariadb-backup is installed at the same time so that `mysql-common` is only installed once from just mariadb repos + apt-get install -y --no-install-recommends mariadb-server="$MARIADB_VERSION" mariadb-backup socat \ + ; \ + rm -rf /var/lib/apt/lists/*; \ +# purge and re-create /var/lib/mysql with appropriate ownership + rm -rf /var/lib/mysql; \ + mkdir -p /var/lib/mysql /var/run/mysqld; \ + chown -R mysql:mysql /var/lib/mysql /var/run/mysqld; \ +# ensure that /var/run/mysqld (used for socket and lock files) is writable regardless of the UID our mysqld instance ends up having at runtime + chmod 777 /var/run/mysqld; \ +# comment out a few problematic configuration values + find /etc/mysql/ -name '*.cnf' -print0 \ + | xargs -0 grep -lZE '^(bind-address|log|user\s)' \ + | xargs -rt -0 sed -Ei 's/^(bind-address|log|user\s)/#&/'; \ +# don't reverse lookup hostnames, they are usually another container + printf "[mariadb]\nhost-cache-size=0\nskip-name-resolve\n" > /etc/mysql/mariadb.conf.d/05-skipcache.cnf; \ +# Issue #327 Correct order of reading directories /etc/mysql/mariadb.conf.d before /etc/mysql/conf.d (mount-point per documentation) + if [ -L /etc/mysql/my.cnf ]; then \ +# 10.5+ + sed -i -e '/includedir/ {N;s/\(.*\)\n\(.*\)/\n\2\n\1/}' /etc/mysql/mariadb.cnf; \ + fi + + +VOLUME /var/lib/mysql + +COPY healthcheck.sh /usr/local/bin/healthcheck.sh +COPY docker-entrypoint.sh /usr/local/bin/ +ENTRYPOINT ["docker-entrypoint.sh"] + +EXPOSE 3306 +CMD ["mariadbd"] diff --git a/11.0/docker-entrypoint.sh b/11.0/docker-entrypoint.sh new file mode 100755 index 0000000..4822661 --- /dev/null +++ b/11.0/docker-entrypoint.sh @@ -0,0 +1,545 @@ +#!/bin/bash +set -eo pipefail +shopt -s nullglob + +# logging functions +mysql_log() { + local type="$1"; shift + printf '%s [%s] [Entrypoint]: %s\n' "$(date --rfc-3339=seconds)" "$type" "$*" +} +mysql_note() { + mysql_log Note "$@" +} +mysql_warn() { + mysql_log Warn "$@" >&2 +} +mysql_error() { + mysql_log ERROR "$@" >&2 + exit 1 +} + +# usage: file_env VAR [DEFAULT] +# ie: file_env 'XYZ_DB_PASSWORD' 'example' +# (will allow for "$XYZ_DB_PASSWORD_FILE" to fill in the value of +# "$XYZ_DB_PASSWORD" from a file, especially for Docker's secrets feature) +file_env() { + local var="$1" + local fileVar="${var}_FILE" + local def="${2:-}" + if [ "${!var:-}" ] && [ "${!fileVar:-}" ]; then + mysql_error "Both $var and $fileVar are set (but are exclusive)" + fi + local val="$def" + if [ "${!var:-}" ]; then + val="${!var}" + elif [ "${!fileVar:-}" ]; then + val="$(< "${!fileVar}")" + fi + export "$var"="$val" + unset "$fileVar" +} + +# set MARIADB_xyz from MYSQL_xyz when MARIADB_xyz is unset +# and make them the same value (so user scripts can use either) +_mariadb_file_env() { + local var="$1"; shift + local maria="MARIADB_${var#MYSQL_}" + file_env "$var" "$@" + file_env "$maria" "${!var}" + if [ "${!maria:-}" ]; then + export "$var"="${!maria}" + fi +} + +# check to see if this file is being run or sourced from another script +_is_sourced() { + # https://unix.stackexchange.com/a/215279 + [ "${#FUNCNAME[@]}" -ge 2 ] \ + && [ "${FUNCNAME[0]}" = '_is_sourced' ] \ + && [ "${FUNCNAME[1]}" = 'source' ] +} + +# usage: docker_process_init_files [file [file [...]]] +# ie: docker_process_init_files /always-initdb.d/* +# process initializer files, based on file extensions +docker_process_init_files() { + # mysql here for backwards compatibility "${mysql[@]}" + # ShellCheck: mysql appears unused. Verify use (or export if used externally) + # shellcheck disable=SC2034 + mysql=( docker_process_sql ) + + echo + local f + for f; do + case "$f" in + *.sh) + # https://github.com/docker-library/postgres/issues/450#issuecomment-393167936 + # https://github.com/docker-library/postgres/pull/452 + if [ -x "$f" ]; then + mysql_note "$0: running $f" + "$f" + else + mysql_note "$0: sourcing $f" + # ShellCheck can't follow non-constant source. Use a directive to specify location. + # shellcheck disable=SC1090 + . "$f" + fi + ;; + *.sql) mysql_note "$0: running $f"; docker_process_sql < "$f"; echo ;; + *.sql.gz) mysql_note "$0: running $f"; gunzip -c "$f" | docker_process_sql; echo ;; + *.sql.xz) mysql_note "$0: running $f"; xzcat "$f" | docker_process_sql; echo ;; + *.sql.zst) mysql_note "$0: running $f"; zstd -dc "$f" | docker_process_sql; echo ;; + *) mysql_warn "$0: ignoring $f" ;; + esac + echo + done +} + +# arguments necessary to run "mariadbd --verbose --help" successfully (used for testing configuration validity and for extracting default/configured values) +_verboseHelpArgs=( + --verbose --help +) + +mysql_check_config() { + local toRun=( "$@" "${_verboseHelpArgs[@]}" ) errors + if ! errors="$("${toRun[@]}" 2>&1 >/dev/null)"; then + mysql_error $'mariadbd failed while attempting to check config\n\tcommand was: '"${toRun[*]}"$'\n\t'"$errors" + fi +} + +# Fetch value from server config +# We use mariadbd --verbose --help instead of my_print_defaults because the +# latter only show values present in config files, and not server defaults +mysql_get_config() { + local conf="$1"; shift + "$@" "${_verboseHelpArgs[@]}" 2>/dev/null \ + | awk -v conf="$conf" '$1 == conf && /^[^ \t]/ { sub(/^[^ \t]+[ \t]+/, ""); print; exit }' + # match "datadir /some/path with/spaces in/it here" but not "--xyz=abc\n datadir (xyz)" +} + +# Do a temporary startup of the MariaDB server, for init purposes +docker_temp_server_start() { + "$@" --skip-networking --default-time-zone=SYSTEM --socket="${SOCKET}" --wsrep_on=OFF \ + --expire-logs-days=0 \ + --loose-innodb_buffer_pool_load_at_startup=0 & + declare -g MARIADB_PID + MARIADB_PID=$! + mysql_note "Waiting for server startup" + # only use the root password if the database has already been initialized + # so that it won't try to fill in a password file when it hasn't been set yet + extraArgs=() + if [ -z "$DATABASE_ALREADY_EXISTS" ]; then + extraArgs+=( '--dont-use-mysql-root-password' ) + fi + local i + for i in {30..0}; do + if docker_process_sql "${extraArgs[@]}" --database=mysql <<<'SELECT 1' &> /dev/null; then + break + fi + sleep 1 + done + if [ "$i" = 0 ]; then + mysql_error "Unable to start server." + fi +} + +# Stop the server. When using a local socket file mariadb-admin will block until +# the shutdown is complete. +docker_temp_server_stop() { + kill "$MARIADB_PID" + wait "$MARIADB_PID" +} + +# Verify that the minimally required password settings are set for new databases. +docker_verify_minimum_env() { + if [ -z "$MARIADB_ROOT_PASSWORD" ] && [ -z "$MARIADB_ROOT_PASSWORD_HASH" ] && [ -z "$MARIADB_ALLOW_EMPTY_ROOT_PASSWORD" ] && [ -z "$MARIADB_RANDOM_ROOT_PASSWORD" ]; then + mysql_error $'Database is uninitialized and password option is not specified\n\tYou need to specify one of MARIADB_ROOT_PASSWORD, MARIADB_ROOT_PASSWORD_HASH, MARIADB_ALLOW_EMPTY_ROOT_PASSWORD and MARIADB_RANDOM_ROOT_PASSWORD' + fi + # More preemptive exclusions of combinations should have been made before *PASSWORD_HASH was added, but for now we don't enforce due to compatibility. + if [ -n "$MARIADB_ROOT_PASSWORD" ] || [ -n "$MARIADB_ALLOW_EMPTY_ROOT_PASSWORD" ] || [ -n "$MARIADB_RANDOM_ROOT_PASSWORD" ] && [ -n "$MARIADB_ROOT_PASSWORD_HASH" ]; then + mysql_error "Cannot specify MARIADB_ROOT_PASSWORD_HASH and another MARIADB_ROOT_PASSWORD* option." + fi + if [ -n "$MARIADB_PASSWORD" ] && [ -n "$MARIADB_PASSWORD_HASH" ]; then + mysql_error "Cannot specify MARIADB_PASSWORD_HASH and MARIADB_PASSWORD option." + fi +} + +# creates folders for the database +# also ensures permission for user mysql of run as root +docker_create_db_directories() { + local user; user="$(id -u)" + + # TODO other directories that are used by default? like /var/lib/mysql-files + # see https://github.com/docker-library/mysql/issues/562 + mkdir -p "$DATADIR" + + if [ "$user" = "0" ]; then + # this will cause less disk access than `chown -R` + find "$DATADIR" \! -user mysql -exec chown mysql: '{}' + + # See https://github.com/MariaDB/mariadb-docker/issues/363 + find "${SOCKET%/*}" -maxdepth 0 \! -user mysql -exec chown mysql: '{}' \; + fi +} + +_mariadb_version() { + local mariaVersion="${MARIADB_VERSION##*:}" + mariaVersion="${mariaVersion%%[-+~]*}" + echo -n "${mariaVersion}-MariaDB" +} + +# initializes the database directory +docker_init_database_dir() { + mysql_note "Initializing database files" + installArgs=( --datadir="$DATADIR" --rpm --auth-root-authentication-method=normal ) + # "Other options are passed to mariadbd." (so we pass all "mysqld" arguments directly here) + mariadb-install-db "${installArgs[@]}" "${@:2}" \ + --skip-test-db \ + --old-mode='UTF8_IS_UTF8MB3' \ + --default-time-zone=SYSTEM --enforce-storage-engine= \ + --skip-log-bin \ + --expire-logs-days=0 \ + --loose-innodb_buffer_pool_load_at_startup=0 \ + --loose-innodb_buffer_pool_dump_at_shutdown=0 + mysql_note "Database files initialized" +} + +# Loads various settings that are used elsewhere in the script +# This should be called after mysql_check_config, but before any other functions +docker_setup_env() { + # Get config + declare -g DATADIR SOCKET + DATADIR="$(mysql_get_config 'datadir' "$@")" + SOCKET="$(mysql_get_config 'socket' "$@")" + + + # Initialize values that might be stored in a file + _mariadb_file_env 'MYSQL_ROOT_HOST' '%' + _mariadb_file_env 'MYSQL_DATABASE' + _mariadb_file_env 'MYSQL_USER' + _mariadb_file_env 'MYSQL_PASSWORD' + _mariadb_file_env 'MYSQL_ROOT_PASSWORD' + # No MYSQL_ compatibility needed for new variables + file_env 'MARIADB_PASSWORD_HASH' + file_env 'MARIADB_ROOT_PASSWORD_HASH' + + # set MARIADB_ from MYSQL_ when it is unset and then make them the same value + : "${MARIADB_ALLOW_EMPTY_ROOT_PASSWORD:=${MYSQL_ALLOW_EMPTY_PASSWORD:-}}" + export MYSQL_ALLOW_EMPTY_PASSWORD="$MARIADB_ALLOW_EMPTY_ROOT_PASSWORD" MARIADB_ALLOW_EMPTY_ROOT_PASSWORD + : "${MARIADB_RANDOM_ROOT_PASSWORD:=${MYSQL_RANDOM_ROOT_PASSWORD:-}}" + export MYSQL_RANDOM_ROOT_PASSWORD="$MARIADB_RANDOM_ROOT_PASSWORD" MARIADB_RANDOM_ROOT_PASSWORD + : "${MARIADB_INITDB_SKIP_TZINFO:=${MYSQL_INITDB_SKIP_TZINFO:-}}" + export MYSQL_INITDB_SKIP_TZINFO="$MARIADB_INITDB_SKIP_TZINFO" MARIADB_INITDB_SKIP_TZINFO + + declare -g DATABASE_ALREADY_EXISTS + if [ -d "$DATADIR/mysql" ]; then + DATABASE_ALREADY_EXISTS='true' + fi +} + +# Execute the client, use via docker_process_sql to handle root password +docker_exec_client() { + # args sent in can override this db, since they will be later in the command + if [ -n "$MYSQL_DATABASE" ]; then + set -- --database="$MYSQL_DATABASE" "$@" + fi + mariadb --protocol=socket -uroot -hlocalhost --socket="${SOCKET}" "$@" +} + +# Execute sql script, passed via stdin +# usage: docker_process_sql [--dont-use-mysql-root-password] [mysql-cli-args] +# ie: docker_process_sql --database=mydb <<<'INSERT ...' +# ie: docker_process_sql --dont-use-mysql-root-password --database=mydb "${DATADIR}/${backup_db}"; then + mysql_error "Unable backup system database for upgrade from $oldfullversion." + fi + mysql_note "Backing up complete" +} + +# perform mariadb-upgrade +# backup the mysql database if this is a major upgrade +docker_mariadb_upgrade() { + if [ -z "$MARIADB_AUTO_UPGRADE" ] \ + || [ "$MARIADB_AUTO_UPGRADE" = 0 ]; then + mysql_note "MariaDB upgrade (mariadb-upgrade) required, but skipped due to \$MARIADB_AUTO_UPGRADE setting" + return + fi + mysql_note "Starting temporary server" + docker_temp_server_start "$@" --skip-grant-tables \ + --loose-innodb_buffer_pool_dump_at_shutdown=0 \ + --skip-slave-start + mysql_note "Temporary server started." + + docker_mariadb_backup_system + + mysql_note "Starting mariadb-upgrade" + mariadb-upgrade --upgrade-system-tables + mysql_note "Finished mariadb-upgrade" + + mysql_note "Stopping temporary server" + docker_temp_server_stop + mysql_note "Temporary server stopped" +} + + +_check_if_upgrade_is_needed() { + if [ ! -f "$DATADIR"/mysql_upgrade_info ]; then + mysql_note "MariaDB upgrade information missing, assuming required" + return 0 + fi + local mariadbVersion + mariadbVersion="$(_mariadb_version)" + IFS='.-' read -ra newversion <<<"$mariadbVersion" + IFS='.-' read -ra oldversion < "$DATADIR"/mysql_upgrade_info || true + + if [[ ${#newversion[@]} -lt 2 ]] || [[ ${#oldversion[@]} -lt 2 ]] \ + || [[ ${oldversion[0]} -lt ${newversion[0]} ]] \ + || [[ ${oldversion[0]} -eq ${newversion[0]} && ${oldversion[1]} -lt ${newversion[1]} ]]; then + return 0 + fi + mysql_note "MariaDB upgrade not required" + return 1 +} + +# check arguments for an option that would cause mariadbd to stop +# return true if there is one +_mysql_want_help() { + local arg + for arg; do + case "$arg" in + -'?'|--help|--print-defaults|-V|--version) + return 0 + ;; + esac + done + return 1 +} + +_main() { + # if command starts with an option, prepend mariadbd + if [ "${1:0:1}" = '-' ]; then + set -- mariadbd "$@" + fi + + #ENDOFSUBSTITUTIONS + # skip setup if they aren't running mysqld or want an option that stops mysqld + if [ "$1" = 'mariadbd' ] || [ "$1" = 'mysqld' ] && ! _mysql_want_help "$@"; then + mysql_note "Entrypoint script for MariaDB Server ${MARIADB_VERSION} started." + + mysql_check_config "$@" + # Load various environment variables + docker_setup_env "$@" + docker_create_db_directories + + # If container is started as root user, restart as dedicated mysql user + if [ "$(id -u)" = "0" ]; then + mysql_note "Switching to dedicated user 'mysql'" + exec gosu mysql "${BASH_SOURCE[0]}" "$@" + fi + + # there's no database, so it needs to be initialized + if [ -z "$DATABASE_ALREADY_EXISTS" ]; then + docker_verify_minimum_env + + # check dir permissions to reduce likelihood of half-initialized database + ls /docker-entrypoint-initdb.d/ > /dev/null + + docker_init_database_dir "$@" + + mysql_note "Starting temporary server" + docker_temp_server_start "$@" + mysql_note "Temporary server started." + + docker_setup_db + docker_process_init_files /docker-entrypoint-initdb.d/* + # Wait until after /docker-entrypoint-initdb.d is performed before setting + # root@localhost password to a hash we don't know the password for. + if [ -n "${MARIADB_ROOT_PASSWORD_HASH}" ]; then + mysql_note "Setting root@localhost password hash" + docker_process_sql --dont-use-mysql-root-password --binary-mode <<-EOSQL + SET @@SESSION.SQL_LOG_BIN=0; + SET PASSWORD FOR 'root'@'localhost'= '${MARIADB_ROOT_PASSWORD_HASH}'; + EOSQL + fi + + mysql_note "Stopping temporary server" + docker_temp_server_stop + mysql_note "Temporary server stopped" + + echo + mysql_note "MariaDB init process done. Ready for start up." + echo + # MDEV-27636 mariadb_upgrade --check-if-upgrade-is-needed cannot be run offline + #elif mariadb-upgrade --check-if-upgrade-is-needed; then + elif _check_if_upgrade_is_needed; then + docker_mariadb_upgrade "$@" + fi + fi + exec "$@" +} + +# If we are sourced from elsewhere, don't perform any further actions +if ! _is_sourced; then + _main "$@" +fi diff --git a/11.0/healthcheck.sh b/11.0/healthcheck.sh new file mode 100755 index 0000000..e995669 --- /dev/null +++ b/11.0/healthcheck.sh @@ -0,0 +1,334 @@ +#!/bin/bash +# +# Healthcheck script for MariaDB +# +# Runs various tests on the MariaDB server to check its health. Pass the tests +# to run as arguments. If all tests succeed, the server is considered healthy, +# otherwise it's not. +# +# Arguments are processed in strict order. Set replication_* options before +# the --replication option. This allows a different set of replication checks +# on different connections. +# +# --su{=|-mariadb} is option to run the healthcheck as a different unix user. +# Useful if mariadb@localhost user exists with unix socket authentication +# Using this option disregards previous options set, so should usually be the +# first option. +# +# Some tests require SQL privileges. +# +# TEST MINIMUM GRANTS REQUIRED +# connect none* +# innodb_initialized USAGE +# innodb_buffer_pool_loaded USAGE +# galera_online USAGE +# replication REPLICATION_CLIENT (<10.5)or REPLICA MONITOR (10.5+) +# mariadbupgrade none, however unix user permissions on datadir +# +# The SQL user used is the default for the mariadb client. This can be the unix user +# if no user(or password) is set in the [mariadb-client] section of a configuration +# file. --defaults-{file,extra-file,group-suffix} can specify a file/configuration +# different from elsewhere. +# +# Note * though denied error message will result in error log without +# any permissions. + +set -eo pipefail + +_process_sql() +{ + mariadb ${nodefaults:+--no-defaults} \ + ${def['file']:+--defaults-file=${def['file']}} \ + ${def['extra_file']:+--defaults-extra-file=${def['extra_file']}} \ + ${def['group_suffix']:+--defaults-group-suffix=${def['group_suffix']}} \ + -B "$@" +} + +# TESTS + + +# CONNECT +# +# Tests that a connection can be made over TCP, the final state +# of the entrypoint and is listening. The authentication used +# isn't tested. +connect() +{ + set +e +o pipefail + mariadb ${nodefaults:+--no-defaults} \ + ${def['file']:+--defaults-file=${def['file']}} \ + ${def['extra_file']:+--defaults-extra-file=${def['extra_file']}} \ + ${def['group_suffix']:+--defaults-group-suffix=${def['group_suffix']}} \ + -h localhost --protocol tcp -e 'select 1' 2>&1 \ + | grep -qF "Can't connect" + local ret=${PIPESTATUS[1]} + set -eo pipefail + if (( "$ret" == 0 )); then + # grep Matched "Can't connect" so we fail + return 1 + fi + return 0 +} + +# INNODB_INITIALIZED +# +# This tests that the crash recovery of InnoDB has completed +# along with all the other things required to make it to a healthy +# operational state. Note this may return true in the early +# states of initialization. Use with a connect test to avoid +# these false positives. +innodb_initialized() +{ + local s + s=$(_process_sql --skip-column-names -e 'select 1 from information_schema.ENGINES WHERE engine="innodb" AND support in ("YES", "DEFAULT", "ENABLED")') + [ "$s" == 1 ] +} + +# INNODB_BUFFER_POOL_LOADED +# +# Tests the load of the innodb buffer pool as been complete +# implies innodb_buffer_pool_load_at_startup=1 (default), or if +# manually SET innodb_buffer_pool_load_now=1 +innodb_buffer_pool_loaded() +{ + local s + s=$(_process_sql --skip-column-names -e 'select VARIABLE_VALUE from information_schema.GLOBAL_STATUS WHERE VARIABLE_NAME="Innodb_buffer_pool_load_status"') + if [[ $s =~ 'load completed' ]]; then + return 0 + fi + return 1 +} + +# GALERA_ONLINE +# +# Tests that the galera node is in the SYNCed state +galera_online() +{ + local s + s=$(_process_sql --skip-column-names -e 'select VARIABLE_VALUE from information_schema.GLOBAL_STATUS WHERE VARIABLE_NAME="WSREP_LOCAL_STATE"') + # 4 from https://galeracluster.com/library/documentation/node-states.html#node-state-changes + # not https://xkcd.com/221/ + if [[ $s -eq 4 ]]; then + return 0 + fi + return 1 +} + +# REPLICATION +# +# Tests the replication has the required set of functions: +# --replication_all -> Checks all replication sources +# --replication_name=n -> sets the multisource connection name tested +# --replication_io -> IO thread is running +# --replication_sql -> SQL thread is running +# --replication_seconds_behind_master=n -> less than or equal this seconds of delay +# --replication_sql_remaining_delay=n -> less than or equal this seconds of remaining delay +# (ref: https://mariadb.com/kb/en/delayed-replication/) +replication() +{ + # SHOW REPLICA available 10.5+ + # https://github.com/koalaman/shellcheck/issues/2383 + # shellcheck disable=SC2016,SC2026 + _process_sql -e "show ${repl['all']:+all} slave${repl['all']:+s} ${repl['name']:+'${repl['name']}'} status\G" | \ + { + # required for trim of leading space. + shopt -s extglob + # Row header + read -t 5 -r + # read timeout + [ $? -gt 128 ] && return 1 + while IFS=":" read -t 1 -r n v; do + # Trim leading space + n=${n##+([[:space:]])} + # Leading space on all values by the \G format needs to be trimmed. + v=${v:1} + case "$n" in + Slave_IO_Running) + if [ -n "${repl['io']}" ] && [ "$v" = 'No' ]; then + return 1 + fi + ;; + Slave_SQL_Running) + if [ -n "${repl['sql']}" ] && [ "$v" = 'No' ]; then + return 1 + fi + ;; + Seconds_Behind_Master) + # A NULL value is the IO thread not running: + if [ -n "${repl['seconds_behind_master']}" ] && + { [ "$v" = NULL ] || + (( "${repl['seconds_behind_master']}" < "$v" )); }; then + return 1 + fi + ;; + SQL_Remaining_Delay) + # Unlike Seconds_Behind_Master, sql_remaining_delay will hit NULL + # once replication is caught up - https://mariadb.com/kb/en/delayed-replication/ + if [ -n "${repl['sql_remaining_delay']}" ] && + [ "$v" != NULL ] && + (( "${repl['sql_remaining_delay']}" < "$v" )); then + return 1 + fi + ;; + esac + done + # read timeout + [ $? -gt 128 ] && return 1 + return 0 + } + # reachable in command not found(?) + # shellcheck disable=SC2317 + return $? +} + +# mariadbupgrade +# +# Test the lock on the file /var/lib/mysql_upgrade_info +# https://jira.mariadb.org/browse/MDEV-27068 +mariadbupgrade() +{ + local f="$datadir/mysql_upgrade_info" + if [ -r "$f" ]; then + flock --exclusive --nonblock -n 9 9<"$f" + return $? + fi + return 0 +} + + +# MAIN + +if [ $# -eq 0 ]; then + echo "At least one argument required" >&2 + exit 1 +fi + +# Marks the end of mariadb -> mariadb name changes in 10.6+ +#ENDOFSUBSTITUTIONS +# Global variables used by tests +declare -A repl +declare -A def +nodefaults= +datadir=/var/lib/mysql + +_repl_param_check() +{ + case "$1" in + seconds_behind_master) ;& + sql_remaining_delay) + if [ -z "${repl['io']}" ]; then + repl['io']=1 + echo "Forcing --replication_io=1, $1 requires IO thread to be running" >&2 + fi + ;; + all) + if [ -n "${repl['name']}" ]; then + unset 'repl[name]' + echo "Option --replication_all incompatible with specified source --replication_name, clearing replication_name" >&2 + fi + ;; + name) + if [ -n "${repl['all']}" ]; then + unset 'repl[all]' + echo "Option --replication_name incompatible with --replication_all, clearing replication_all" >&2 + fi + ;; + esac +} + +_test_exists() { + declare -F "$1" > /dev/null + return $? +} + +while [ $# -gt 0 ]; do + case "$1" in + --su=*) + u="${1#*=}" + shift + exec gosu "${u}" "${BASH_SOURCE[0]}" "$@" + ;; + --su) + shift + u=$1 + shift + exec gosu "$u" "${BASH_SOURCE[0]}" "$@" + ;; + --su-mysql) + shift + exec gosu mysql "${BASH_SOURCE[0]}" "$@" + ;; + --replication_*=*) + # Change the n to what is between _ and = and make lower case + n=${1#*_} + n=${n%%=*} + n=${n,,*} + # v is after the = + v=${1#*=} + repl[$n]=$v + _repl_param_check "$n" + ;; + --replication_*) + # Without =, look for a non --option next as the value, + # otherwise treat it as an "enable", just equate to 1. + # Clearing option is possible with "--replication_X=" + n=${1#*_} + n=${n,,*} + if [ "${2:0:2}" == '--' ]; then + repl[$n]=1 + else + repl[$n]=$2 + shift + fi + _repl_param_check "$n" + ;; + --datadir=*) + datadir=${1#*=} + ;; + --datadir) + shift + datadir=${1} + ;; + --no-defaults) + unset def + nodefaults=1 + ;; + --defaults-file=*|--defaults-extra-file=*|--defaults-group-suffix=*) + n=${1:11} # length --defaults- + n=${n%%=*} + n=${n//-/_} + # v is after the = + v=${1#*=} + def[$n]=$v + nodefaults= + ;; + --defaults-file|--defaults-extra-file|--defaults-group-suffix) + n=${1:11} # length --defaults- + n=${n//-/_} + if [ "${2:0:2}" == '--' ]; then + def[$n]="" + else + def[$n]=$2 + shift + fi + nodefaults= + ;; + --*) + test=${1#--} + ;; + *) + echo "Unknown healthcheck option $1" >&2 + exit 1 + esac + if [ -n "$test" ]; then + if ! _test_exists "$test" ; then + echo "healthcheck unknown option or test '$test'" >&2 + exit 1 + elif ! "$test"; then + echo "healthcheck $test failed" >&2 + exit 1 + fi + test= + fi + shift +done From d73bf53c91aa11e423a186c9a6daacd5e3fef002 Mon Sep 17 00:00:00 2001 From: Daniel Black Date: Tue, 7 Feb 2023 18:53:21 +1100 Subject: [PATCH 2/7] MDEV-30498: 11.0 with mariadb_upgrade_info --- 11.0/docker-entrypoint.sh | 8 ++++---- 11.0/healthcheck.sh | 4 ++-- update.sh | 4 ++++ 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/11.0/docker-entrypoint.sh b/11.0/docker-entrypoint.sh index 4822661..d544c3f 100755 --- a/11.0/docker-entrypoint.sh +++ b/11.0/docker-entrypoint.sh @@ -403,8 +403,8 @@ docker_mariadb_backup_system() fi local backup_db="system_mysql_backup_unknown_version.sql.zst" local oldfullversion="unknown_version" - if [ -r "$DATADIR"/mysql_upgrade_info ]; then - read -r -d '' oldfullversion < "$DATADIR"/mysql_upgrade_info || true + if [ -r "$DATADIR"/mariadb_upgrade_info ]; then + read -r -d '' oldfullversion < "$DATADIR"/mariadb_upgrade_info || true if [ -n "$oldfullversion" ]; then backup_db="system_mysql_backup_${oldfullversion}.sql.zst" fi @@ -444,14 +444,14 @@ docker_mariadb_upgrade() { _check_if_upgrade_is_needed() { - if [ ! -f "$DATADIR"/mysql_upgrade_info ]; then + if [ ! -f "$DATADIR"/mariadb_upgrade_info ]; then mysql_note "MariaDB upgrade information missing, assuming required" return 0 fi local mariadbVersion mariadbVersion="$(_mariadb_version)" IFS='.-' read -ra newversion <<<"$mariadbVersion" - IFS='.-' read -ra oldversion < "$DATADIR"/mysql_upgrade_info || true + IFS='.-' read -ra oldversion < "$DATADIR"/mariadb_upgrade_info || true if [[ ${#newversion[@]} -lt 2 ]] || [[ ${#oldversion[@]} -lt 2 ]] \ || [[ ${oldversion[0]} -lt ${newversion[0]} ]] \ diff --git a/11.0/healthcheck.sh b/11.0/healthcheck.sh index e995669..76d3f75 100755 --- a/11.0/healthcheck.sh +++ b/11.0/healthcheck.sh @@ -183,11 +183,11 @@ replication() # mariadbupgrade # -# Test the lock on the file /var/lib/mysql_upgrade_info +# Test the lock on the file /var/lib/mariadb_upgrade_info # https://jira.mariadb.org/browse/MDEV-27068 mariadbupgrade() { - local f="$datadir/mysql_upgrade_info" + local f="$datadir/mariadb_upgrade_info" if [ -r "$f" ]; then flock --exclusive --nonblock -n 9 9<"$f" return $? diff --git a/update.sh b/update.sh index 3fe6323..7df6360 100755 --- a/update.sh +++ b/update.sh @@ -83,6 +83,10 @@ update_version() -e 's/-\$MARIADB_MAJOR//' \ "$version/Dockerfile" fi + if [ "$version" = 11.0 ]; then + sed -i -e 's/mysql_upgrade_info/mariadb_upgrade_info/' \ + "$version/docker-entrypoint.sh" "$version/healthcheck.sh" + fi ;& esac } From e509c5c5294b57b090e0f4770446aca76c49e856 Mon Sep 17 00:00:00 2001 From: Faustin Lammler Date: Fri, 17 Feb 2023 10:52:34 +0100 Subject: [PATCH 3/7] Improve bash scripts - generate-stackbrew-library.sh: needs bashbrew and needs to exit immediately if not available. - update.sh: prepare for testing with DEV Rest API. --- generate-stackbrew-library.sh | 17 ++++++++++++++--- update.sh | 20 +++++++++++--------- 2 files changed, 25 insertions(+), 12 deletions(-) diff --git a/generate-stackbrew-library.sh b/generate-stackbrew-library.sh index 37dce5f..696ca36 100755 --- a/generate-stackbrew-library.sh +++ b/generate-stackbrew-library.sh @@ -1,6 +1,11 @@ #!/usr/bin/env bash set -Eeuo pipefail +err() { + echo >&2 "ERROR: $*" + exit 1 +} + declare -A aliases=( #[10.3]='10 latest' #[5.5]='5' @@ -12,6 +17,12 @@ declare -A latest=() self="$(basename "$BASH_SOURCE")" cd "$(dirname "$(readlink -f "$BASH_SOURCE")")" +# needed by .architectures-lib +# https://github.com/docker-library/bashbrew/releases +command -v bashbrew >/dev/null || { + err "bashbrew: command not found" +} + source '.architectures-lib' GLOBIGNORE=.*/:test/ @@ -79,7 +90,7 @@ for version in "${versions[@]}"; do versionAliases+=( ${version}${suffix} ) fi - versionAliases+=( ${aliases[$version]:-} ) + versionAliases+=( "${aliases[$version]:-}" ) if [ "$releaseStatus" = 'Stable' ]; then for tryAlias in "${version%%.*}" latest; do if [ -z "${latest[$tryAlias]:-}" ]; then @@ -96,7 +107,7 @@ for version in "${versions[@]}"; do variantAliases=( "${versionAliases[@]/%/-$suite}" ) versionAliases=( "${variantAliases[@]//latest-/}" "${versionAliases[@]}" ) - arches=$(versionArches $version) + arches=$(versionArches "$version") for arch in $arches; do # Debify the arch @@ -115,7 +126,7 @@ for version in "${versions[@]}"; do echo cat <<-EOE Tags: $(join ', ' "${versionAliases[@]}") - Architectures: $(join ', ' $arches) + Architectures: $(join ', ' "$arches") GitCommit: $commit Directory: $version EOE diff --git a/update.sh b/update.sh index 7df6360..0d3d09c 100755 --- a/update.sh +++ b/update.sh @@ -28,6 +28,9 @@ declare -A suffix=( # [s390x]='s390x' #) +# For testing with https://downloads.dev.mariadb.org/rest-api +typeset -r DOWNLOADS_REST_API="https://downloads.mariadb.org/rest-api" + update_version() { echo "$version: $mariaVersion ($releaseStatus)" @@ -91,16 +94,15 @@ update_version() esac } -mariaversion() -{ - mariaVersion=$( curl -fsSL https://downloads.mariadb.org/rest-api/mariadb/"${version}" \ - | jq 'first(..|select(.release_id)) | .release_id' ) - mariaVersion=${mariaVersion//\"} +mariaversion() { + mariaVersion=$(curl -fsSL "$DOWNLOADS_REST_API/mariadb/${version}" | + jq 'first(..|select(.release_id)) | .release_id') + mariaVersion=${mariaVersion//\"/} } all() { - curl -fsSL https://downloads.mariadb.org/rest-api/mariadb/ \ + curl -fsSL "$DOWNLOADS_REST_API/mariadb/" \ | jq '.major_releases[] | [ .release_id ], [ .release_status ] | @tsv ' \ | while read -r version do @@ -113,7 +115,7 @@ all() read -r releaseStatus releaseStatus=${releaseStatus//\"} - + case "$releaseStatus" in Alpha | Beta | Gamma | RC | Stable ) ;; # sanity check "Old Stable" ) @@ -156,9 +158,9 @@ for version in "${versions[@]}"; do else mariaversion fi - releaseStatus=$(curl -fsSL https://downloads.mariadb.org/rest-api/mariadb/ \ + releaseStatus=$(curl -fsSL "$DOWNLOADS_REST_API/mariadb/" \ | jq ".major_releases[] | select(.release_id == \"$version\") | .release_status") releaseStatus=${releaseStatus//\"} - + update_version done From 9539fd6240375643e024bb05247660d7f396a123 Mon Sep 17 00:00:00 2001 From: Daniel Black Date: Thu, 23 Feb 2023 18:56:44 +1100 Subject: [PATCH 4/7] 11.0 update + healthcheck.sh typo --- 10.10/healthcheck.sh | 2 +- 10.11/healthcheck.sh | 2 +- 10.3/healthcheck.sh | 2 +- 10.4/healthcheck.sh | 2 +- 10.5/healthcheck.sh | 2 +- 10.6/healthcheck.sh | 2 +- 10.7/healthcheck.sh | 2 +- 10.8/healthcheck.sh | 2 +- 10.9/healthcheck.sh | 2 +- 11.0/healthcheck.sh | 2 +- healthcheck.sh | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-) diff --git a/10.10/healthcheck.sh b/10.10/healthcheck.sh index e995669..bdc2011 100755 --- a/10.10/healthcheck.sh +++ b/10.10/healthcheck.sh @@ -183,7 +183,7 @@ replication() # mariadbupgrade # -# Test the lock on the file /var/lib/mysql_upgrade_info +# Test the lock on the file /var/lib/mariadb/mysql_upgrade_info # https://jira.mariadb.org/browse/MDEV-27068 mariadbupgrade() { diff --git a/10.11/healthcheck.sh b/10.11/healthcheck.sh index e995669..bdc2011 100755 --- a/10.11/healthcheck.sh +++ b/10.11/healthcheck.sh @@ -183,7 +183,7 @@ replication() # mariadbupgrade # -# Test the lock on the file /var/lib/mysql_upgrade_info +# Test the lock on the file /var/lib/mariadb/mysql_upgrade_info # https://jira.mariadb.org/browse/MDEV-27068 mariadbupgrade() { diff --git a/10.3/healthcheck.sh b/10.3/healthcheck.sh index c81a4ab..d5e65a0 100755 --- a/10.3/healthcheck.sh +++ b/10.3/healthcheck.sh @@ -183,7 +183,7 @@ replication() # mariadbupgrade # -# Test the lock on the file /var/lib/mysql_upgrade_info +# Test the lock on the file /var/lib/mysql/mysql_upgrade_info # https://jira.mariadb.org/browse/MDEV-27068 mariadbupgrade() { diff --git a/10.4/healthcheck.sh b/10.4/healthcheck.sh index c81a4ab..d5e65a0 100755 --- a/10.4/healthcheck.sh +++ b/10.4/healthcheck.sh @@ -183,7 +183,7 @@ replication() # mariadbupgrade # -# Test the lock on the file /var/lib/mysql_upgrade_info +# Test the lock on the file /var/lib/mysql/mysql_upgrade_info # https://jira.mariadb.org/browse/MDEV-27068 mariadbupgrade() { diff --git a/10.5/healthcheck.sh b/10.5/healthcheck.sh index c81a4ab..d5e65a0 100755 --- a/10.5/healthcheck.sh +++ b/10.5/healthcheck.sh @@ -183,7 +183,7 @@ replication() # mariadbupgrade # -# Test the lock on the file /var/lib/mysql_upgrade_info +# Test the lock on the file /var/lib/mysql/mysql_upgrade_info # https://jira.mariadb.org/browse/MDEV-27068 mariadbupgrade() { diff --git a/10.6/healthcheck.sh b/10.6/healthcheck.sh index e995669..bdc2011 100755 --- a/10.6/healthcheck.sh +++ b/10.6/healthcheck.sh @@ -183,7 +183,7 @@ replication() # mariadbupgrade # -# Test the lock on the file /var/lib/mysql_upgrade_info +# Test the lock on the file /var/lib/mariadb/mysql_upgrade_info # https://jira.mariadb.org/browse/MDEV-27068 mariadbupgrade() { diff --git a/10.7/healthcheck.sh b/10.7/healthcheck.sh index e995669..bdc2011 100755 --- a/10.7/healthcheck.sh +++ b/10.7/healthcheck.sh @@ -183,7 +183,7 @@ replication() # mariadbupgrade # -# Test the lock on the file /var/lib/mysql_upgrade_info +# Test the lock on the file /var/lib/mariadb/mysql_upgrade_info # https://jira.mariadb.org/browse/MDEV-27068 mariadbupgrade() { diff --git a/10.8/healthcheck.sh b/10.8/healthcheck.sh index e995669..bdc2011 100755 --- a/10.8/healthcheck.sh +++ b/10.8/healthcheck.sh @@ -183,7 +183,7 @@ replication() # mariadbupgrade # -# Test the lock on the file /var/lib/mysql_upgrade_info +# Test the lock on the file /var/lib/mariadb/mysql_upgrade_info # https://jira.mariadb.org/browse/MDEV-27068 mariadbupgrade() { diff --git a/10.9/healthcheck.sh b/10.9/healthcheck.sh index e995669..bdc2011 100755 --- a/10.9/healthcheck.sh +++ b/10.9/healthcheck.sh @@ -183,7 +183,7 @@ replication() # mariadbupgrade # -# Test the lock on the file /var/lib/mysql_upgrade_info +# Test the lock on the file /var/lib/mariadb/mysql_upgrade_info # https://jira.mariadb.org/browse/MDEV-27068 mariadbupgrade() { diff --git a/11.0/healthcheck.sh b/11.0/healthcheck.sh index 76d3f75..c1d1fad 100755 --- a/11.0/healthcheck.sh +++ b/11.0/healthcheck.sh @@ -183,7 +183,7 @@ replication() # mariadbupgrade # -# Test the lock on the file /var/lib/mariadb_upgrade_info +# Test the lock on the file /var/lib/mariadb/mariadb_upgrade_info # https://jira.mariadb.org/browse/MDEV-27068 mariadbupgrade() { diff --git a/healthcheck.sh b/healthcheck.sh index c81a4ab..d5e65a0 100755 --- a/healthcheck.sh +++ b/healthcheck.sh @@ -183,7 +183,7 @@ replication() # mariadbupgrade # -# Test the lock on the file /var/lib/mysql_upgrade_info +# Test the lock on the file /var/lib/mysql/mysql_upgrade_info # https://jira.mariadb.org/browse/MDEV-27068 mariadbupgrade() { From b49ba2780bd3f78b527308f9664162ebca3e16d8 Mon Sep 17 00:00:00 2001 From: Daniel Black Date: Thu, 23 Feb 2023 19:11:19 +1100 Subject: [PATCH 5/7] 11.0.1 properly --- 11.0/Dockerfile | 8 ++++---- update.sh | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/11.0/Dockerfile b/11.0/Dockerfile index e2a2236..d84d99e 100644 --- a/11.0/Dockerfile +++ b/11.0/Dockerfile @@ -75,17 +75,17 @@ LABEL org.opencontainers.image.authors="MariaDB Community" \ org.opencontainers.image.licenses="GPL-2.0" \ org.opencontainers.image.source="https://github.com/MariaDB/mariadb-docker" \ org.opencontainers.image.vendor="MariaDB Community" \ - org.opencontainers.image.version="11.0.0" \ + org.opencontainers.image.version="11.0.1" \ org.opencontainers.image.url="https://github.com/MariaDB/mariadb-docker" # bashbrew-architectures: amd64 arm64v8 ppc64le s390x -ARG MARIADB_VERSION=1:11.0.0+maria~ubu2204 +ARG MARIADB_VERSION=1:11.0.1+maria~ubu2204 ENV MARIADB_VERSION $MARIADB_VERSION -# release-status:Alpha +# release-status:RC # (https://downloads.mariadb.org/rest-api/mariadb/) # Allowing overriding of REPOSITORY, a URL that includes suite and component for testing and Enterprise Versions -ARG REPOSITORY="http://archive.mariadb.org/mariadb-11.0.0/repo/ubuntu/ jammy main" +ARG REPOSITORY="http://archive.mariadb.org/mariadb-11.0.1/repo/ubuntu/ jammy main" RUN set -e;\ echo "deb ${REPOSITORY}" > /etc/apt/sources.list.d/mariadb.list; \ diff --git a/update.sh b/update.sh index 0d3d09c..7c407ec 100755 --- a/update.sh +++ b/update.sh @@ -128,7 +128,7 @@ all() done } -development_version=11.0 +development_version=11.1 in_development() { From 6c359e6c2366babb8e72aa944948374d41a03fe3 Mon Sep 17 00:00:00 2001 From: Faustin Lammler Date: Thu, 23 Feb 2023 09:45:01 +0100 Subject: [PATCH 6/7] Rollback quoting arrays Result is wrong when generating library/mariadb for the docker-official-images repo. --- generate-stackbrew-library.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/generate-stackbrew-library.sh b/generate-stackbrew-library.sh index 696ca36..74642d6 100755 --- a/generate-stackbrew-library.sh +++ b/generate-stackbrew-library.sh @@ -90,7 +90,7 @@ for version in "${versions[@]}"; do versionAliases+=( ${version}${suffix} ) fi - versionAliases+=( "${aliases[$version]:-}" ) + versionAliases+=( ${aliases[$version]:-} ) if [ "$releaseStatus" = 'Stable' ]; then for tryAlias in "${version%%.*}" latest; do if [ -z "${latest[$tryAlias]:-}" ]; then @@ -107,7 +107,7 @@ for version in "${versions[@]}"; do variantAliases=( "${versionAliases[@]/%/-$suite}" ) versionAliases=( "${variantAliases[@]//latest-/}" "${versionAliases[@]}" ) - arches=$(versionArches "$version") + arches=$(versionArches $version) for arch in $arches; do # Debify the arch @@ -126,7 +126,7 @@ for version in "${versions[@]}"; do echo cat <<-EOE Tags: $(join ', ' "${versionAliases[@]}") - Architectures: $(join ', ' "$arches") + Architectures: $(join ', ' $arches) GitCommit: $commit Directory: $version EOE From 19a8ec41b623194698eb3a52ca84c61a7bfd3bec Mon Sep 17 00:00:00 2001 From: Daniel Black Date: Fri, 24 Feb 2023 08:49:05 +1100 Subject: [PATCH 7/7] test: cases for 11.0+ - no "mysql" or "mysql_upgrade_info" --- .test/initdb.d/a_first.sh | 6 ++++++ .test/run.sh | 36 ++++++++++++++++++++++-------------- 2 files changed, 28 insertions(+), 14 deletions(-) diff --git a/.test/initdb.d/a_first.sh b/.test/initdb.d/a_first.sh index d8724cc..bde4de0 100755 --- a/.test/initdb.d/a_first.sh +++ b/.test/initdb.d/a_first.sh @@ -1,5 +1,11 @@ #!/bin/sh PASS="${MARIADB_PASSWORD:-$MYSQL_PASSWORD}" +if [ -x /usr/bin/mariadb ]; then + mysql() + { + mariadb "$@" + } +fi mysql -u "${MARIADB_USER:-$MYSQL_USER}" -p"${PASS}" \ -e 'create table t1 (i int unsigned primary key not null)' \ "${MARIADB_DATABASE:-$MYSQL_DATABASE}" diff --git a/.test/run.sh b/.test/run.sh index e783568..4d3f6a0 100755 --- a/.test/run.sh +++ b/.test/run.sh @@ -120,8 +120,10 @@ othertables=$(mariadbclient -u root --skip-column-names -Be "select group_concat otherusers=$(mariadbclient -u root --skip-column-names -Be "select user,host from mysql.user where (user,host) not in (('root', 'localhost'), ('root', '%'), ('mariadb.sys', 'localhost'))") [ "$otherusers" != '' ] && die "unexpected users $otherusers" - echo "Contents of /var/lib/mysql/mysql_upgrade_info:" - docker exec "$cid" cat /var/lib/mysql/mysql_upgrade_info || die "missing mysql_upgrade_info on install" + echo "Contents of /var/lib/mysql/{mysql,mariadb}_upgrade_info:" + docker exec "$cid" cat /var/lib/mysql/mysql_upgrade_info \ + || docker exec "$cid" cat /var/lib/mysql/mariadb_upgrade_info \ + || die "missing {mariadb,mysql_upgrade}_info on install" echo killoff @@ -478,16 +480,22 @@ fi docker exec "$cid" ls -la /var/lib/mysql/ echo "Final upgrade info reflects current version?" - docker exec "$cid" cat /var/lib/mysql/mysql_upgrade_info || die "missing mysql_upgrade_info on install" + if docker exec "$cid" cat /var/lib/mysql/mysql_upgrade_info; then + upgrade_file=mysql_upgrade_info + elif docker exec "$cid" cat /var/lib/mysql/mysql_upgrade_info; then + upgrade_file=mariadb_upgrade_info + else + die "missing {mysql,mariadb}_upgrade_info on install" + fi echo - upgradeversion=$(docker exec "$cid" cat /var/lib/mysql/mysql_upgrade_info) + upgradeversion=$(docker exec "$cid" cat /var/lib/mysql/$upgrade_file) # note VERSION() is longer [[ $version =~ ^${upgradeversion} ]] || die "upgrade version didn't match" echo "fix version to 5.x" - docker exec "$cid" sed -i -e 's/[0-9]*\(.*\)/5\1/' /var/lib/mysql/mysql_upgrade_info - docker exec "$cid" cat /var/lib/mysql/mysql_upgrade_info + docker exec "$cid" sed -i -e 's/[0-9]*\(.*\)/5\1/' /var/lib/mysql/$upgrade_file + docker exec "$cid" cat /var/lib/mysql/$upgrade_file killoff runandwait -e MARIADB_AUTO_UPGRADE=1 -v m57:/var/lib/mysql:Z "${image}" @@ -505,19 +513,19 @@ fi echo echo "Final upgrade info reflects current version?" - docker exec "$cid" cat /var/lib/mysql/mysql_upgrade_info || die "missing mysql_upgrade_info on install" - upgradeversion=$(docker exec "$cid" cat /var/lib/mysql/mysql_upgrade_info) + docker exec "$cid" cat /var/lib/mysql/$upgrade_file || die "missing mysql_upgrade_info on install" + upgradeversion=$(docker exec "$cid" cat /var/lib/mysql/$upgrade_file) [[ $version =~ ^${upgradeversion} ]] || die "upgrade version didn't match current version" echo echo "Fixing back to 0 minor version" - docker exec "$cid" sed -i -e 's/[0-9]*-\(MariaDB\)/0-\1/' /var/lib/mysql/mysql_upgrade_info - upgradeversion=$(docker exec "$cid" cat /var/lib/mysql/mysql_upgrade_info) + docker exec "$cid" sed -i -e 's/[0-9]*-\(MariaDB\)/0-\1/' /var/lib/mysql/$upgrade_file + upgradeversion=$(docker exec "$cid" cat /var/lib/mysql/$upgrade_file) killoff runandwait -e MARIADB_AUTO_UPGRADE=1 -v m57:/var/lib/mysql:Z "${image}" - docker exec "$cid" cat /var/lib/mysql/mysql_upgrade_info - newupgradeversion=$(docker exec "$cid" cat /var/lib/mysql/mysql_upgrade_info) + docker exec "$cid" cat /var/lib/mysql/$upgrade_file + newupgradeversion=$(docker exec "$cid" cat /var/lib/mysql/$upgrade_file) [ "$upgradeversion" = "$newupgradeversion" ] || die "upgrade versions from mysql_upgrade_info should match" docker logs "$cid" 2>&1 | grep -C 5 'MariaDB upgrade not required' || die 'should not have upgraded' @@ -528,7 +536,7 @@ fi encryption) echo -e "Test: Startup using encryption \n" - runandwait -v "${dir}"/encryption_conf/:/etc/mysql/conf.d/ -v "${dir}"/encryption:/etc/encryption/ -v "${dir}"/initenc:/docker-entrypoint-initdb.d/ \ + runandwait -v "${dir}"/encryption_conf/:/etc/mysql/conf.d/:z -v "${dir}"/encryption:/etc/encryption/:z -v "${dir}"/initenc:/docker-entrypoint-initdb.d/:z \ -e MARIADB_ALLOW_EMPTY_ROOT_PASSWORD=1 -e MARIADB_DATABASE=bob -e MARIADB_USER=bob -e MARIADB_PASSWORD=hope "${image}" mariadbclient -u root -e 'SELECT * FROM information_schema.innodb_tablespaces_encryption' || die 'Failed to start container' @@ -537,7 +545,7 @@ fi [ "$cnt" -gt 0 ] || die 'Failed to initialize encryption on initialization' killoff ;& -binlog) + binlog) echo -e "Test: Ensure timezoneinfo isn't written to binary log\n"