1berry/kutt
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

use count(*) instead of count(id) since it's slightly faster

Browse Source
This commit is contained in:
Pouria Ezzati 2025-01-18 12:56:27 +03:30
parent de103423e3
commit 876d12fc9d
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server/queries/domain.queries.js
View File

@ -160,7 +160,7 @@ async function getAdmin(match, params) {
} }
query.leftJoin( query.leftJoin(
knex("links").select("domain_id").count("id as links_count").groupBy("domain_id").as("l"), knex("links").select("domain_id").count("* as links_count").groupBy("domain_id").as("l"),
"domains.id", "domains.id",
"l.domain_id" "l.domain_id"
); );
@ -195,7 +195,7 @@ async function totalAdmin(match, params) {
if (params?.links !== undefined) { if (params?.links !== undefined) {
query.leftJoin( query.leftJoin(
knex("links").select("domain_id").count("id as links_count").groupBy("domain_id").as("l"), knex("links").select("domain_id").count("* as links_count").groupBy("domain_id").as("l"),
"domains.id", "domains.id",
"l.domain_id" "l.domain_id"
); );
@ -203,7 +203,7 @@ async function totalAdmin(match, params) {
} }
query.leftJoin("users", "domains.user_id", "users.id"); query.leftJoin("users", "domains.user_id", "users.id");
query.count("domains.id as count"); query.count("* as count");
const [{ count }] = await query; const [{ count }] = await query;

4
server/queries/link.queries.js
View File

@ -70,7 +70,7 @@ async function total(match, params) {
); );
} }
query.leftJoin("domains", "links.domain_id", "domains.id"); query.leftJoin("domains", "links.domain_id", "domains.id");
query.count("links.id as count"); query.count("* as count");
const [{ count }] = await query; const [{ count }] = await query;
@ -106,7 +106,7 @@ async function totalAdmin(match, params) {
query.leftJoin("domains", "links.domain_id", "domains.id"); query.leftJoin("domains", "links.domain_id", "domains.id");
query.leftJoin("users", "links.user_id", "users.id"); query.leftJoin("users", "links.user_id", "users.id");
query.count("links.id as count"); query.count("* as count");
const [{ count }] = await query; const [{ count }] = await query;

8
server/queries/user.queries.js
View File

@ -169,7 +169,7 @@ async function getAdmin(match, params) {
"d.user_id" "d.user_id"
) )
query.leftJoin( query.leftJoin(
knex("links").select("user_id").count("id as links_count").groupBy("user_id").as("l"), knex("links").select("user_id").count("* as links_count").groupBy("user_id").as("l"),
"users.id", "users.id",
"l.user_id" "l.user_id"
); );
@ -179,7 +179,7 @@ async function getAdmin(match, params) {
async function totalAdmin(match, params) { async function totalAdmin(match, params) {
const query = knex("users") const query = knex("users")
.count("users.id as count") .count("* as count")
.fromRaw('users') .fromRaw('users')
.where(normalizeMatch(match)); .where(normalizeMatch(match));
@ -209,13 +209,13 @@ async function totalAdmin(match, params) {
if (params?.links !== undefined) { if (params?.links !== undefined) {
query.andWhere("links", params?.links ? "is not" : "is", null); query.andWhere("links", params?.links ? "is not" : "is", null);
query.leftJoin( query.leftJoin(
knex("links").select("user_id").count("id as links").groupBy("user_id").as("l"), knex("links").select("user_id").count("* as links").groupBy("user_id").as("l"),
"users.id", "users.id",
"l.user_id" "l.user_id"
); );
} }
const [{count}] = await query; const [{ count }] = await query;
return typeof count === "number" ? count : parseInt(count); return typeof count === "number" ? count : parseInt(count);
} }