1berry/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MINOR: cpu-topo: use cpufreq before acpi cppc

Browse Source 
The acpi_cppc method was found to take about 5ms per CPU on a 64-core
EPYC system, which is plain unacceptable as it delays the boot by half
a second. Let's use the less accurate cpufreq first, which should be
sufficient anyway since many systems do not have acpi_cppc. We'll only
fall back to acpi_cppc for systems without cpufreq. If it were to be
an issue over time, we could also automatically consider that all
threads of the same core or even of the same cluster run at the same
speed (when a cluster is known to be accurate).
This commit is contained in:
Willy Tarreau 2025-03-12 13:28:24 +01:00
parent d11241b7ba
commit e4aa13e786
1 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/cpu_topo.c
View File

@ -413,23 +413,26 @@ int cpu_detect_topology(void)
* as high as 260 were seen there. Note that only nominal_perf
* is trustable, as nominal_freq may return zero. It's also
* more reliable than the max cpufreq values because it doesn't
* seem to take into account the die quality.
* seem to take into account the die quality. However, acpi_cppc
* can be super slow on some systems (5ms per access noticed on
* a 64-core EPYC), making haproxy literally take seconds to
* start just due to this. Thus we start with cpufreq and fall
* back to acpi_cppc. If it becomes an issue, we could imagine
* forcing the value to all members of the same core and even
* cluster.
*/
if (ha_cpu_topo[cpu].capa < 0 &&
read_line_to_trash(NUMA_DETECT_SYSTEM_SYSFS_PATH "/cpu/cpu%d/cpufreq/scaling_max_freq", cpu) >= 0) {
/* This is in kHz, turn it to MHz to stay below 32k */
if (trash.data)
ha_cpu_topo[cpu].capa = (str2uic(trash.area) + 999U) / 1000U;
}
if (ha_cpu_topo[cpu].capa < 0 &&
read_line_to_trash(NUMA_DETECT_SYSTEM_SYSFS_PATH "/cpu/cpu%d/acpi_cppc/nominal_perf", cpu) >= 0) {
if (trash.data)
ha_cpu_topo[cpu].capa = str2uic(trash.area);
}
/* Finally if none of them is available we can have a look at
* cpufreq's max cpu frequency.
*/
if (ha_cpu_topo[cpu].capa < 0 &&
read_line_to_trash(NUMA_DETECT_SYSTEM_SYSFS_PATH "/cpu/cpu%d/cpufreq/scaling_max_freq", cpu) >= 0) {
/* This is in kHz turn it to MHz to stay below 32k */
if (trash.data)
ha_cpu_topo[cpu].capa = (str2uic(trash.area) + 999U) / 1000U;
}
}
/* Now locate NUMA node IDs if any */