From e3e218b98e59fe10339a8894e87b879694d78ed6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Fri, 8 Sep 2023 10:17:25 +0200 Subject: [PATCH] CLEANUP: quic: Remove useless free_quic_tx_pkts() function. This function define but no more used since this commit: BUG/MAJOR: quic: Really ignore malformed ACK frames. --- include/haproxy/quic_tx.h | 1 - src/quic_tx.c | 16 ---------------- 2 files changed, 17 deletions(-) diff --git a/include/haproxy/quic_tx.h b/include/haproxy/quic_tx.h index b3702cc88..f22ebe03f 100644 --- a/include/haproxy/quic_tx.h +++ b/include/haproxy/quic_tx.h @@ -40,7 +40,6 @@ int quic_build_post_handshake_frames(struct quic_conn *qc); int qc_send_app_pkts(struct quic_conn *qc, struct list *frms); int qc_dgrams_retransmit(struct quic_conn *qc); int qc_notify_send(struct quic_conn *qc); -void free_quic_tx_pkts(struct quic_conn *qc, struct list *pkts); void qc_prep_hdshk_fast_retrans(struct quic_conn *qc, struct list *ifrms, struct list *hfrms); int quic_generate_retry_token_aad(unsigned char *aad, diff --git a/src/quic_tx.c b/src/quic_tx.c index e63b44a24..cc1147b93 100644 --- a/src/quic_tx.c +++ b/src/quic_tx.c @@ -79,22 +79,6 @@ static inline void free_quic_tx_packet(struct quic_conn *qc, TRACE_LEAVE(QUIC_EV_CONN_TXPKT, qc); } -/* Free the TX packets of list */ -void free_quic_tx_pkts(struct quic_conn *qc, struct list *pkts) -{ - struct quic_tx_packet *pkt, *tmp; - - TRACE_ENTER(QUIC_EV_CONN_TXPKT, qc); - - list_for_each_entry_safe(pkt, tmp, pkts, list) { - LIST_DELETE(&pkt->list); - eb64_delete(&pkt->pn_node); - free_quic_tx_packet(qc, pkt); - } - - TRACE_LEAVE(QUIC_EV_CONN_TXPKT, qc); -} - /* Duplicate all frames from list into list * for QUIC connection. * This is a best effort function which never fails even if no memory could be