1berry/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MAJOR: mux-quic: increase stream flow-control for multi-buffer alloc

Browse Source 
Support for multiple Rx buffers per QCS instance has been introduced by
previous patches. However, due to flow-control initial values, client
were still unable to fully used this to increase their upload
throughput.

This patch increases max-stream-data-bidi-remote flow-control initial
values. A new define QMUX_STREAM_RX_BUF_FACTOR will fix the number of
concurrent buffers allocable per QCS. It is set to 90.

Note that connection flow-control initial value did not changed. It is
still configured to be equivalent to bufsize multiplied by the maximum
concurrent streams. This ensures that Rx buffers allocation is still
constrained per connection, so that it won't be possible to have all
active QCS instances using in parallel their maximum Rx buffers count.
This commit is contained in:
Amaury Denoyelle 2025-03-04 15:25:44 +01:00
parent 75027692a3
commit dc7913d814
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
include/haproxy/mux_quic.h
View File

@ -51,6 +51,9 @@ static inline int qmux_stream_rx_bufsz(void)
return global.tune.bufsize - NCB_RESERVED_SZ;
}
/* Number of buffers usable on Rx per QCS instance. */
#define QMUX_STREAM_RX_BUF_FACTOR 90
/* Bit shift to get the stream sub ID for internal use which is obtained
* shifting the stream IDs by this value, knowing that the
* QCS_ID_TYPE_SHIFT less significant bits identify the stream ID

2
src/quic_tp.c
View File

@ -65,7 +65,7 @@ void quic_transport_params_init(struct quic_transport_params *p, int server)
p->initial_max_streams_bidi = max_streams_bidi;
p->initial_max_streams_uni = max_streams_uni;
p->initial_max_stream_data_bidi_local = stream_rx_bufsz;
p->initial_max_stream_data_bidi_remote = stream_rx_bufsz;
p->initial_max_stream_data_bidi_remote = stream_rx_bufsz * QMUX_STREAM_RX_BUF_FACTOR;
p->initial_max_stream_data_uni = stream_rx_bufsz;
p->initial_max_data = (max_streams_bidi + max_streams_uni) * stream_rx_bufsz;