1berry/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MINOR: backend: do not overwrite srv dst address on reuse

Browse Source 
Previously, destination address of backend connection was systematically
always reassigned. However, this step is unnecessary on connection
reuse. Indeed, reuse should only be conducted with connection using the
same destination address matching the stream requirements.

This patch removes this unnecessary assignment. It is now only performed
when reuse cannot be conducted and a new connection is instantiated.

Functionnally speaking, this patch should not change anything in theory,
as reuse is performed in conformance with the destination address.
However, it appears that it was not always properly enforced. The
systematic assignment of the destination address hides these issues, so
it is now remove. The identified bogus cases will then be fixed in the
following patches.would

This should be backported up to all stable versions.
This commit is contained in:
Amaury Denoyelle 2025-03-27 17:06:06 +01:00
parent c05bb8c967
commit d7fa8e88c4
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend.c
View File

@ -1869,6 +1869,9 @@ skip_reuse:
srv_conn->src = bind_addr;
bind_addr = NULL;
/* copy the target address into the connection */
*srv_conn->dst = *s->scb->dst;
/* mark? */
if (s->flags & SF_BC_MARK) {
srv_conn->mark = s->bc_mark;
@ -1893,10 +1896,6 @@ skip_reuse:
if (!srv_conn)
return SF_ERR_RESOURCE;
/* copy the target address into the connection */
if (s->scb->dst)
*srv_conn->dst = *s->scb->dst;
/* Copy network namespace from client connection */
srv_conn->proxy_netns = cli_conn ? cli_conn->proxy_netns : NULL;