From d6ae912b04a38a544b2d37f549c7f86ae51e929c Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Fri, 3 Dec 2021 08:58:22 +0100 Subject: [PATCH] BUILD: bug: Fix error when compiling with -DDEBUG_STRICT_NOCRASH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ha_backtrace_to_stderr() must be declared in CRASH_NOW() macro whe HAProxy is compiled with DEBUG_STRICT_NOCRASH. Otherwise an error is reported during compilation: include/haproxy/bug.h:58:26: error: implicit declaration of function ‘ha_backtrace_to_stderr’ [-Werror=implicit-function-declaration] 58 | #define CRASH_NOW() do { ha_backtrace_to_stderr(); } while (0) This patch must be backported as far as 2.4. --- include/haproxy/bug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/haproxy/bug.h b/include/haproxy/bug.h index 45c97ba67..52a1ebe6b 100644 --- a/include/haproxy/bug.h +++ b/include/haproxy/bug.h @@ -55,7 +55,7 @@ #if defined(DEBUG_STRICT) #define CRASH_NOW() ABORT_NOW() #else -#define CRASH_NOW() do { ha_backtrace_to_stderr(); } while (0) +#define CRASH_NOW() do { extern void ha_backtrace_to_stderr(void); ha_backtrace_to_stderr(); } while (0) #endif #define BUG_ON(cond) _BUG_ON(cond, __FILE__, __LINE__)