From b00c00e82ccffe61cb6c9de78c0a6dd6a6a40207 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Fri, 2 Apr 2021 17:47:21 +0200 Subject: [PATCH] CONTRIB: halog: fix issue with array of type char I just noticed this in the windows build after moving the file to dev/: In file included from include/import/ist.h:32, from include/haproxy/connection-t.h:32, from dev/flags/flags.c:5: dev/flags/flags.c: In function `main': dev/flags/flags.c:442:20: error: array subscript has type `char' [-Werror=char-subscripts] 442 | (isalnum(*err) && toupper(*err) != 'U' && toupper(*err) != 'L')) | ^~~~ LD haproxy cc1: all warnings being treated as errors make: *** [Makefile:932: dev/flags/flags.o] Error 1 make: *** Waiting for unfinished jobs.... Error: Process completed with exit code 2. Let's just cast it to uchar as is done everywhere else. --- contrib/debug/flags.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/debug/flags.c b/contrib/debug/flags.c index 044221ea4..669bd090c 100644 --- a/contrib/debug/flags.c +++ b/contrib/debug/flags.c @@ -439,7 +439,7 @@ int main(int argc, char **argv) /* stop at the end of the number and trim any C suffix like "UL" */ err = value; while (*err == '-' || *err == '+' || - (isalnum(*err) && toupper(*err) != 'U' && toupper(*err) != 'L')) + (isalnum((unsigned char)*err) && toupper((unsigned char)*err) != 'U' && toupper((unsigned char)*err) != 'L')) err++; if (err) *err = 0;