From ac1ca5cc7b69df0c3cfc218ca5645b2f36bd8421 Mon Sep 17 00:00:00 2001 From: Aurelien DARRAGON Date: Tue, 22 Nov 2022 11:48:12 +0100 Subject: [PATCH] CLEANUP: arg: remove extra check in make_arg_list arg escaping Len cannot be equal to 1 when entering in escape handling code. But yet, an extra "len == 1" check was performed. Removing this useless check. This was reported by Ilya with the help of cppcheck. --- src/arg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/arg.c b/src/arg.c index 17f5ed061..2810050b0 100644 --- a/src/arg.c +++ b/src/arg.c @@ -182,7 +182,7 @@ int make_arg_list(const char *in, int len, uint64_t mask, struct arg **argp, } else if (*in == '\\' && !squote && len != 1) { /* '\', ', ' ', '"' support being escaped by '\' */ - if (len == 1 || in[1] == 0) + if (in[1] == 0) goto unquote_err; if (in[1] == '\\' || in[1] == ' ' || in[1] == '"' || in[1] == '\'') {