1berry/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MEDIUM: applet: Don't call .release callback function twice

Browse Source 
Since the CS/SI refactoring, the .release callback function may be called
twice. The first call when a shutdown for read or for write is performed.
The second one when the applet is detached from its conn-stream. The second
call must be guarded, just like the first one, to only be performed is the
stream-interface is not the in disconnected (SI_ST_DIS) or closed
(SI_ST_CLO) state.

To simplify the fix, we now always rely on si_applet_release() function.

It is 2.6-specific, no backport is needed.
This commit is contained in:
Christopher Faulet 2022-03-15 11:29:59 +01:00
parent 8f170c7fca
commit 9affa931cd
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/conn_stream.c
View File

@ -129,8 +129,8 @@ void cs_detach_endp(struct conn_stream *cs)
}
}
else if ((appctx = cs_appctx(cs))) {
if (appctx->applet->release)
appctx->applet->release(appctx);
if (cs->si)
si_applet_release(cs->si);
appctx_free(appctx);
}