From 91a88b0c2568a28c4c830a7eb10c3d8fb5b1e8cb Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 17 Nov 2017 08:47:25 +0000 Subject: [PATCH] BUG/MEDIUM: deviceatlas: ignore not valuable HTTP request data A customer reported a crash when within the HTTP request some headers were not set leading to the module to crash. So the module ignore them since empty data have no value for the detection. Needs to be backported to 1.7. --- src/da.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/da.c b/src/da.c index c31855d52..09b0e3ec9 100644 --- a/src/da.c +++ b/src/da.c @@ -318,7 +318,7 @@ static int da_haproxy_fetch(const struct arg *args, struct sample *smp, const ch char hbuf[24] = { 0 }; /* The HTTP headers used by the DeviceAtlas API are not longer */ - if (hctx.del >= sizeof(hbuf)) { + if (hctx.del >= sizeof(hbuf) || hctx.del <= 0 || hctx.vlen <= 0) { continue; }