From 8c573deb9f95ae3171440d682b08abccda234e6d Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Wed, 11 Jun 2025 21:39:19 +0200 Subject: [PATCH] BUG/MINOR: hlua: Don't forget the return statement after a hlua_yieldk() In hlua_applet_tcp_getline_yield(), the function may yield if there is no data available. However we must take care to add a return statement just after the call to hlua_yieldk(). I don't know the details of the LUA API, but at least, this return statement fix a build error about uninitialized variables that may be used. It is a 3.3-specific issue. No backport needed. --- src/hlua.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/hlua.c b/src/hlua.c index 4a3a76f7e..b1c2fa4df 100644 --- a/src/hlua.c +++ b/src/hlua.c @@ -5312,6 +5312,7 @@ __LJMP static int hlua_applet_tcp_getline_yield(lua_State *L, int status, lua_KC if (ret == 0) { applet_need_more_data(luactx->appctx); MAY_LJMP(hlua_yieldk(L, 0, 0, hlua_applet_tcp_getline_yield, TICK_ETERNITY, 0)); + return 0; } /* End of data: commit the total strings and return. */