1berry/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MINOR: hlua_fcn: enforce yield after *_get_stats() methods

Browse Source 
{listener,proxy,server}_get_stats() methods are know to be expensive,
expecially if used under an iteration. Indeed, while automatic yield
is performed every X lua instructions (defaults to 10k), computing an
object's stats 10K times in a single cpu loop is not desirable and
could create contention.

In this patch we leverage hlua_yield_asap() at the end of *_get_stats()
methods in order to force the automatic yield to occur ASAP after the
method returns. Hopefully this should help in similar scenarios as the
one described in GH #2903
This commit is contained in:
Aurelien DARRAGON 2025-04-30 16:41:16 +02:00
parent 97363015a5
commit 7f418ac7d2
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/hlua_fcn.c
View File

@ -1154,6 +1154,7 @@ int hlua_listener_get_stats(lua_State *L)
hlua_fcn_pushfield(L, &stats[i]); hlua_fcn_pushfield(L, &stats[i]);
lua_settable(L, -3); lua_settable(L, -3);
} }
hlua_yield_asap(L);
return 1; return 1;
} }
@ -1200,6 +1201,7 @@ int hlua_server_get_stats(lua_State *L)
hlua_fcn_pushfield(L, &stats[i]); hlua_fcn_pushfield(L, &stats[i]);
lua_settable(L, -3); lua_settable(L, -3);
} }
hlua_yield_asap(L);
return 1; return 1;
} }
@ -2053,6 +2055,7 @@ int hlua_proxy_get_stats(lua_State *L)
hlua_fcn_pushfield(L, &stats[i]); hlua_fcn_pushfield(L, &stats[i]);
lua_settable(L, -3); lua_settable(L, -3);
} }
hlua_yield_asap(L);
return 1; return 1;
} }