1berry/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MEDIUM: quic: fix null deref on error path in qc_conn_init()

Browse Source 
When ctx is NULL, we go to the "err" label, which could dereference it.
No backport is needed.
This commit is contained in:
Willy Tarreau 2021-05-10 07:40:27 +02:00
parent 714f28ceef
commit 7deb28ce65
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/xprt_quic.c
View File

@ -4164,7 +4164,7 @@ static int qc_conn_init(struct connection *conn, void **xprt_ctx)
return 0; return 0;
err: err:
if (ctx->wait_event.tasklet) if (ctx && ctx->wait_event.tasklet)
tasklet_free(ctx->wait_event.tasklet); tasklet_free(ctx->wait_event.tasklet);
pool_free(pool_head_quic_conn_ctx, ctx); pool_free(pool_head_quic_conn_ctx, ctx);
TRACE_DEVEL("leaving in error", QUIC_EV_CONN_NEW, conn); TRACE_DEVEL("leaving in error", QUIC_EV_CONN_NEW, conn);