1berry/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MINOR: mux-h1: Fix trace message in h1_detroy() to not relay on connection

Browse Source 
h1_destroy() may be called to release a H1C after a multiplexer upgrade. In
that case, the connection is no longer attached to the H1C. It must not be
used in the h1 trace message because the connection context is no longer a H1C.

Because of this bug, when a H1>H2 upgrade is performed, a crash may be
experienced if the H1 traces are enabled.

This patch must be backport to all stable versions.
This commit is contained in:
Christopher Faulet 2025-04-30 14:32:16 +02:00
parent 2dc334be61
commit 7dc4e94830
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mux_h1.c
View File

@ -4488,7 +4488,7 @@ static void h1_destroy(void *ctx)
{
struct h1c *h1c = ctx;
TRACE_POINT(H1_EV_H1C_END, h1c->conn);
TRACE_POINT(H1_EV_H1C_END);
if (!h1c->h1s || h1c->conn->ctx != h1c)
h1_release(h1c);
}