1berry/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MINOR: backend: mark srv as nonnull in alloc_dst_address()

Browse Source 
Server instance can be NULL on connect_server(), either when dispatch or
transparent proxy are active. However, in alloc_dst_address() access to
<srv> is safe thanks to SF_ASSIGNED stream flag. Add an ASSUME_NONNULL()
to reflect this state.

This should fix coverity report from github issue #2922.
This commit is contained in:
Amaury Denoyelle 2025-04-03 15:17:53 +02:00
parent feb1a9ea17
commit 76e9156c9b
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend.c
View File

@ -888,6 +888,8 @@ static int alloc_dst_address(struct sockaddr_storage **ss,
if (!sockaddr_alloc(ss, NULL, 0)) if (!sockaddr_alloc(ss, NULL, 0))
return SRV_STATUS_INTERNAL; return SRV_STATUS_INTERNAL;
ASSUME_NONNULL(srv); /* srv is guaranteed by SF_ASSIGNED */
**ss = srv->addr; **ss = srv->addr;
set_host_port(*ss, srv->svc_port); set_host_port(*ss, srv->svc_port);
if (!is_addr(*ss)) { if (!is_addr(*ss)) {