1berry/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MEDIUM: spop-conn: Report short read for partial frames payload

Browse Source 
When a frame was not fully received, a short read must be reported on the
SPOP connection to help the demux to handle truncated frames. This was
performed for frames truncated on the header part but not on the payload
part. It is now properly detected.

This patch must be backported to 3.1.
This commit is contained in:
Christopher Faulet 2025-05-14 09:20:08 +02:00
parent ddc5f8d92e
commit 71feb49a9f
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mux_spop.c
View File

@ -1643,6 +1643,7 @@ static int spop_conn_handle_hello(struct spop_conn *spop_conn)
/* process full record only */
if (b_data(dbuf) < (spop_conn->dfl)) {
spop_conn->flags |= SPOP_CF_DEM_SHORT_READ;
TRACE_DEVEL("leaving on missing data", SPOP_EV_RX_FRAME|SPOP_EV_RX_HELLO, spop_conn->conn);
return 0;
}
@ -1814,6 +1815,7 @@ static int spop_conn_handle_disconnect(struct spop_conn *spop_conn)
/* process full record only */
if (b_data(dbuf) < (spop_conn->dfl)) {
spop_conn->flags |= SPOP_CF_DEM_SHORT_READ;
TRACE_DEVEL("leaving on missing data", SPOP_EV_RX_FRAME|SPOP_EV_RX_DISCO, spop_conn->conn);
return 0;
}
@ -1925,6 +1927,7 @@ static int spop_conn_handle_ack(struct spop_conn *spop_conn, struct spop_strm *s
/* process full record only */
if (b_data(dbuf) < (spop_conn->dfl)) {
spop_conn->flags |= SPOP_CF_DEM_SHORT_READ;
TRACE_DEVEL("leaving on missing data", SPOP_EV_RX_FRAME|SPOP_EV_RX_DISCO, spop_conn->conn);
return 0;
}