1berry/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MINOR: hlua_fcn: fix Patref:set() force parameter

Browse Source 
Patref:set(key, val[, force]) takes optional "force" parameter (defaults
to false) to force the entry to be created if it doesn't already exist

To retrieve the value, lua_tointeger() was used in place of
lua_toboolean(), and because of that force is not enabled if "true"
is passed as parameter (only numbers were recognized) despite the
documentation mentioning that "force" is a boolean.

To fix the issue, we replace lua_tointeger by lua_toboolean.

Also, the doc was updated to rename "bool" to "boolean" for the "force"
parameter to stay consistent with historical naming in the file.

No backport needed unless 9ee37de5c ("MINOR: hlua_fcn: add Patref:set()")
is.
This commit is contained in:
Aurelien DARRAGON 2024-11-29 07:33:51 +01:00
parent e5acb03137
commit 4e52438c0b
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/lua-api/index.rst
View File

@ -3558,7 +3558,7 @@ Patref class
:param string key: the string used as a key
:param string value: the string used as value
:param bool force: create the entry if it doesn't exist (optional,
:param boolean force: create the entry if it doesn't exist (optional,
defaults to false)
:returns: true on success and nil on failure (followed by an error message)

2
src/hlua_fcn.c
View File

@ -2889,7 +2889,7 @@ int hlua_patref_set(lua_State *L)
value = luaL_checkstring(L, 3);
if (lua_gettop(L) == 4)
force = lua_tointeger(L, 4);
force = lua_toboolean(L, 4);
HA_RWLOCK_WRLOCK(PATREF_LOCK, &ref->ptr->lock);
if ((ref->flags & HLUA_PATREF_FL_GEN) &&