1berry/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CLEANUP: quic: Useless tests in qc_rx_pkt_handle()

Browse Source 
There is no reason to test <qc> nullity at the end of this function because it is
clearly not null, furthermore the trace handle the case where <qc> is null.

Must be backported to 2.7.
This commit is contained in:
Frdric Lcaille 2023-05-24 10:24:42 +02:00 committed by Willy Tarreau
parent ab3aa0ff22
commit 464281af46
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/quic_conn.c
View File

@ -7373,8 +7373,8 @@ static void qc_rx_pkt_handle(struct quic_conn *qc, struct quic_rx_packet *pkt,
drop: drop:
HA_ATOMIC_INC(&qc->prx_counters->dropped_pkt); HA_ATOMIC_INC(&qc->prx_counters->dropped_pkt);
TRACE_PROTO("packet drop", QUIC_EV_CONN_LPKT, qc ? qc : NULL, pkt, NULL, qv); TRACE_PROTO("packet drop", QUIC_EV_CONN_LPKT, qc, pkt, NULL, qv);
TRACE_LEAVE(QUIC_EV_CONN_LPKT, qc ? qc : NULL); TRACE_LEAVE(QUIC_EV_CONN_LPKT, qc);
} }
/* This function builds into a buffer at <pos> position a QUIC long packet header, /* This function builds into a buffer at <pos> position a QUIC long packet header,