1berry/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MINOR: acme: fix possible NULL deref

Browse Source 
Task was dereferenced when setting ctx but was checked after.
This patch move the setting of ctx after the check.

Should fix issue #2931
This commit is contained in:
William Lallemand 2025-04-15 11:36:26 +02:00
parent 3cbbf41cd8
commit 3866d3bd12
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/acme.c
View File

@ -493,11 +493,13 @@ REGISTER_CONFIG_SECTION("acme", cfg_parse_acme, cfg_postsection_acme);
static void acme_httpclient_end(struct httpclient *hc) static void acme_httpclient_end(struct httpclient *hc)
{ {
struct task *task = hc->caller; struct task *task = hc->caller;
struct acme_ctx *ctx = task->context; struct acme_ctx *ctx;
if (!task) if (!task)
return; return;
ctx = task->context;
if (ctx->http_state == ACME_HTTP_REQ) if (ctx->http_state == ACME_HTTP_REQ)
ctx->http_state = ACME_HTTP_RES; ctx->http_state = ACME_HTTP_RES;