1berry/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MINOR: quic: prevent crash on startup with -dt

Browse Source 
QUIC traces in ssl_quic_srv_new_ssl_ctx() are problematic as this
function is called early during startup. If activating traces via -dt
command-line argument, a crash occurs due to stderr sink not yet
available.

Thus, traces from ssl_quic_srv_new_ssl_ctx() are simply removed.

No backport needed.
This commit is contained in:
Amaury Denoyelle 2025-06-12 15:15:56 +02:00
parent 5a0ae9e9be
commit 33cd96a5e9
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/quic_ssl.c
View File

@ -780,13 +780,9 @@ SSL_CTX *ssl_quic_srv_new_ssl_ctx(void)
SSL_OP_SINGLE_ECDH_USE | SSL_OP_SINGLE_ECDH_USE |
SSL_OP_CIPHER_SERVER_PREFERENCE; SSL_OP_CIPHER_SERVER_PREFERENCE;
TRACE_ENTER(QUIC_EV_CONN_NEW);
ctx = SSL_CTX_new(TLS_client_method()); ctx = SSL_CTX_new(TLS_client_method());
if (!ctx) { if (!ctx)
TRACE_ERROR("Could not allocate a new TLS context", QUIC_EV_CONN_NEW);
goto err; goto err;
}
SSL_CTX_set_options(ctx, options); SSL_CTX_set_options(ctx, options);
SSL_CTX_set_min_proto_version(ctx, TLS1_3_VERSION); SSL_CTX_set_min_proto_version(ctx, TLS1_3_VERSION);
@ -797,12 +793,10 @@ SSL_CTX *ssl_quic_srv_new_ssl_ctx(void)
#endif #endif
leave: leave:
TRACE_LEAVE(QUIC_EV_CONN_NEW);
return ctx; return ctx;
err: err:
SSL_CTX_free(ctx); SSL_CTX_free(ctx);
ctx = NULL; ctx = NULL;
TRACE_DEVEL("leaving on error", QUIC_EV_CONN_NEW);
goto leave; goto leave;
} }