From 2f7f65e159439a418ee842f3fdff32108df29bbb Mon Sep 17 00:00:00 2001 From: William Lallemand Date: Tue, 29 Apr 2025 11:29:52 +0200 Subject: [PATCH] BUG/MINOR: acme: does not try to unlock after a failed trylock Return after a failed trylock in acme_update_certificate() instead of jumping to the error label which does an unlock. --- src/acme.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/acme.c b/src/acme.c index 13241a745..45d701409 100644 --- a/src/acme.c +++ b/src/acme.c @@ -706,8 +706,7 @@ int acme_update_certificate(struct task *task, struct acme_ctx *ctx, char **errm if (HA_SPIN_TRYLOCK(CKCH_LOCK, &ckch_lock)) { memprintf(errmsg, "couldn't get the certificate lock!"); - goto error; - + return ret; } if ((old_ckchs = ckchs_lookup(new_ckchs->path)) == NULL) {