1berry/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

DOC: design: update the notes on thread groups

Browse Source 
Some (few) elements were already done, others were clarified and worth
mentionning.
This commit is contained in:
Willy Tarreau 2022-06-10 16:05:59 +02:00
parent c6b7a97e54
commit 1424774207
1 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
doc/design-thoughts/thread-group.txt
View File

@ -381,14 +381,23 @@ the FD, and all those with a bit in it ought to do it.
2021-09-13 - tid / tgroups etc. 2021-09-13 - tid / tgroups etc.
========== ==========
- tid currently is the thread's global ID. It's essentially used as an index * tid currently is the thread's global ID. It's essentially used as an index
for arrays. It must be clearly stated that it works this way. for arrays. It must be clearly stated that it works this way.
* tasklets use the global thread id, and __tasklet_wakeup_on() must use a
global ID as well. It's capital that tinfo[] provides instant access to
local/global bits/indexes/arrays
- tid_bit makes no sense process-wide, so it must be redefined to represent - tid_bit makes no sense process-wide, so it must be redefined to represent
the thread's tid within its group. The name is not much welcome though, but the thread's tid within its group. The name is not much welcome though, but
there are 286 of it that are not going to be changed that fast. there are 286 of it that are not going to be changed that fast.
=> now we have ltid and ltid_bit in thread_info. thread-local tid_bit still
not changed though. If renamed we must make sure the older one vanishes.
Why not rename "ptid, ptid_bit" for the process-wide tid and "gtid,
gtid_bit" for the group-wide ones ? This removes the ambiguity on "tid"
which is half the time not the one we expect.
- just like "ti" is the thread_info, we need to have "tg" pointing to the * just like "ti" is the thread_info, we need to have "tg" pointing to the
thread_group. thread_group.
- other less commonly used elements should be retrieved from ti->xxx. E.g. - other less commonly used elements should be retrieved from ti->xxx. E.g.
@ -396,8 +405,13 @@ the FD, and all those with a bit in it ought to do it.
- lock debugging must reproduce tgid - lock debugging must reproduce tgid
- an offset might be placed in the tgroup so that even with 64 threads max - task profiling must be made per-group (annoying), unless we want to add a
per-thread TH_FL_* flag and have the rare places where the bit is changed
iterate over all threads if needed. Sounds preferable overall.
* an offset might be placed in the tgroup so that even with 64 threads max
we could have completely separate tid_bits over several groups. we could have completely separate tid_bits over several groups.
=> base and count now
2021-09-15 - bind + listen() + rx 2021-09-15 - bind + listen() + rx
========== ==========