From 10eed8ed039891ea71a0e8a87d9bfd47eb5dff94 Mon Sep 17 00:00:00 2001 From: Amaury Denoyelle Date: Thu, 18 Nov 2021 13:48:57 +0100 Subject: [PATCH] BUG/MINOR: quic: fix version negotiation packet generation Fix wrong memcpy usage for source and connection ID in generated Version Negotiation packet. --- src/xprt_quic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/xprt_quic.c b/src/xprt_quic.c index ca1e44f6b..2aaf9babd 100644 --- a/src/xprt_quic.c +++ b/src/xprt_quic.c @@ -3527,12 +3527,12 @@ static int qc_send_version_negotiation(int fd, struct sockaddr_storage *addr, /* source connection id */ buf[i++] = pkt->scid.len; - memcpy(buf, pkt->scid.data, pkt->scid.len); + memcpy(&buf[i], pkt->scid.data, pkt->scid.len); i += pkt->scid.len; /* destination connection id */ buf[i++] = pkt->dcid.len; - memcpy(buf, pkt->dcid.data, pkt->dcid.len); + memcpy(&buf[i], pkt->dcid.data, pkt->dcid.len); i += pkt->dcid.len; /* supported version */