From 0fa5adee3bb17814b80ddfb5e07f5e219efcfebd Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Sat, 4 Nov 2023 08:12:17 +0100 Subject: [PATCH] MINOR: mux-h2: always use h2_send() in h2_done_ff(), not h2_process() By calling h2_process(), the code would theoretically make it possible for a synchronous ->wake() call to provoke an indirect call to h2_snd_buf() while we're in h2_done_ff(), which could be quite bad. The current conditions do not permit it right now but this could easily break by accident. Better use h2_send() and wake the task up if needed. Precise performance tests showed no change. --- src/mux_h2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mux_h2.c b/src/mux_h2.c index 785fbd9cd..d0ab3c8a0 100644 --- a/src/mux_h2.c +++ b/src/mux_h2.c @@ -7070,7 +7070,8 @@ static void h2_done_ff(struct stconn *sc) b_add(mbuf, 9); h2s->sws -= sd->iobuf.data; h2c->mws -= sd->iobuf.data; - h2_process(h2c); + if (h2_send(h2s->h2c)) + tasklet_wakeup(h2s->h2c->wait_event.tasklet); end: sd->iobuf.buf = NULL;