1berry/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MINOR: quic: fix race condition on datagram purging

Browse Source 
Each datagram is received by a random thread and dispatch to its
destination thread linked to the connection. Then, the datagram is
handled by the connection thread. Once this is done, datagram buffer
pointer is atomically set to NULL to mark it as consumed.

Consumed datagrams are purged before recvfrom() invocation on random
receiver threads. The check for NULL buffer must thus be done
atomically. This was not the case before this patch, which may have
triggered race conditions.

This bug has been introduced by commit
  91b2305ad79bb7086840797b6e98bd791992444f
  MINOR: quic: implement datagram cleanup for quic_receiver_buf

This should be backported up to 2.6 after previously mentionned commit.
This commit is contained in:
Amaury Denoyelle 2022-10-25 11:38:21 +02:00
parent 735b44f5df
commit 0b13e94071
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/quic_sock.c
View File

@ -223,7 +223,7 @@ static struct quic_dgram *quic_rxbuf_purge_dgrams(struct quic_receiver_buf *buf)
cur = LIST_ELEM(buf->dgram_list.n, struct quic_dgram *, recv_list); cur = LIST_ELEM(buf->dgram_list.n, struct quic_dgram *, recv_list);
/* Loop until a not yet consumed datagram is found. */ /* Loop until a not yet consumed datagram is found. */
if (cur->buf) if (HA_ATOMIC_LOAD(&cur->buf))
break; break;
/* Clear buffer of current unused datagram. */ /* Clear buffer of current unused datagram. */