1berry/go
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cmd/go,cmd/compile: re-enable concurrent compilation on darwin/arm64

Browse Source 
I've manually reviewed all uses of ctxt.Flag_shared for concurrency safety.
And I manually tested with the race detector and found no issues.
Allow -shared to be used with compiler concurrency,
thereby re-enabling concurrent compilation on darwin/arm64.

Fixes #48496

Change-Id: I8a084cb08e6050950e404ceb9bd7e3a20e07e9c5
Reviewed-on: https://go-review.googlesource.com/c/go/+/353871
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
This commit is contained in:
Josh Bleecher Snyder 2021-10-04 12:14:10 -07:00
parent 7d822af450
commit 579ff8b131
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/compile/internal/base/flag.go
View File

@ -357,7 +357,7 @@ func concurrentBackendAllowed() bool {
return false return false
} }
// TODO: fix races and enable the following flags // TODO: fix races and enable the following flags
if Ctxt.Flag_shared || Ctxt.Flag_dynlink || Flag.Race { if Ctxt.Flag_dynlink || Flag.Race {
return false return false
} }
return true return true

2
src/cmd/go/internal/work/gc.go
View File

@ -234,7 +234,7 @@ CheckFlags:
// except for known commonly used flags. // except for known commonly used flags.
// If the user knows better, they can manually add their own -c to the gcflags. // If the user knows better, they can manually add their own -c to the gcflags.
switch flag { switch flag {
case "-N", "-l", "-S", "-B", "-C", "-I": case "-N", "-l", "-S", "-B", "-C", "-I", "-shared":
// OK // OK
default: default:
canDashC = false canDashC = false