1berry/docker-compose
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: concurrent map writes when pulling

Browse Source 
Signed-off-by: skanehira <sho19921005@gmail.com>
This commit is contained in:
skanehira 2025-04-17 11:13:23 +09:00 committed by Nicolas De loof
parent a96c305b25
commit bf6b447263
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/compose/pull.go
View File

@ -24,6 +24,7 @@ import (
"fmt" "fmt"
"io" "io"
"strings" "strings"
"sync"
"time" "time"
"github.com/compose-spec/compose-go/v2/types" "github.com/compose-spec/compose-go/v2/types"
@ -322,9 +323,12 @@ func (s *composeService) pullRequiredImages(ctx context.Context, project *types.
eg, ctx := errgroup.WithContext(ctx) eg, ctx := errgroup.WithContext(ctx)
eg.SetLimit(s.maxConcurrency) eg.SetLimit(s.maxConcurrency)
pulledImages := map[string]api.ImageSummary{} pulledImages := map[string]api.ImageSummary{}
var mutex sync.Mutex
for name, service := range needPull { for name, service := range needPull {
eg.Go(func() error { eg.Go(func() error {
id, err := s.pullServiceImage(ctx, service, s.configFile(), w, quietPull, project.Environment["DOCKER_DEFAULT_PLATFORM"]) id, err := s.pullServiceImage(ctx, service, s.configFile(), w, quietPull, project.Environment["DOCKER_DEFAULT_PLATFORM"])
mutex.Lock()
defer mutex.Unlock()
pulledImages[name] = api.ImageSummary{ pulledImages[name] = api.ImageSummary{
ID: id, ID: id,
Repository: service.Image, Repository: service.Image,