d5e6e2ec6e
Change completion for nodes to use names by default, and bring back
support for the `DOCKER_COMPLETION_SHOW_NODE_IDS` env-var
f9ced58158/contrib/completion/bash/docker (L38)
With this patch:
docker node ps <tab>
docker-desktop self
export DOCKER_COMPLETION_SHOW_NODE_IDS=yes
docker node ps <TAB>
docker-desktop qyeriqk20al6hy4y869d08ff5 self
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
39 lines
1.1 KiB
Go
39 lines
1.1 KiB
Go
package node
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/docker/cli/cli"
|
|
"github.com/docker/cli/cli/command"
|
|
"github.com/docker/docker/api/types/swarm"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
func newPromoteCommand(dockerCli command.Cli) *cobra.Command {
|
|
return &cobra.Command{
|
|
Use: "promote NODE [NODE...]",
|
|
Short: "Promote one or more nodes to manager in the swarm",
|
|
Args: cli.RequiresMinArgs(1),
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
return runPromote(cmd.Context(), dockerCli, args)
|
|
},
|
|
ValidArgsFunction: completeNodeNames(dockerCli),
|
|
}
|
|
}
|
|
|
|
func runPromote(ctx context.Context, dockerCli command.Cli, nodes []string) error {
|
|
promote := func(node *swarm.Node) error {
|
|
if node.Spec.Role == swarm.NodeRoleManager {
|
|
_, _ = fmt.Fprintf(dockerCli.Out(), "Node %s is already a manager.\n", node.ID)
|
|
return errNoRoleChange
|
|
}
|
|
node.Spec.Role = swarm.NodeRoleManager
|
|
return nil
|
|
}
|
|
success := func(nodeID string) {
|
|
_, _ = fmt.Fprintf(dockerCli.Out(), "Node %s promoted to a manager in the swarm.\n", nodeID)
|
|
}
|
|
return updateNodes(ctx, dockerCli, nodes, promote, success)
|
|
}
|