d47d2338b7
Same functionality, but implemented with atomicwriter. There's a slight
difference in error-messages produced (but can be adjusted if we want).
Before:
docker image save -o ./no/such/foo busybox:latest
failed to save image: invalid output path: directory "no/such" does not exist
docker image save -o /no/permissions busybox:latest
failed to save image: stat /no/permissions: permission denied
After:
docker image save -o ./no/such/foo busybox:latest
failed to save image: invalid file path: stat no/such: no such file or directory
docker image save -o /no/permissions busybox:latest
failed to save image: failed to stat output path: lstat /no/permissions: permission denied
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
87 lines
2.4 KiB
Go
87 lines
2.4 KiB
Go
package image
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
|
|
"github.com/containerd/platforms"
|
|
"github.com/docker/cli/cli"
|
|
"github.com/docker/cli/cli/command"
|
|
"github.com/docker/cli/cli/command/completion"
|
|
"github.com/docker/docker/client"
|
|
"github.com/moby/sys/atomicwriter"
|
|
"github.com/pkg/errors"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
type saveOptions struct {
|
|
images []string
|
|
output string
|
|
platform string
|
|
}
|
|
|
|
// NewSaveCommand creates a new `docker save` command
|
|
func NewSaveCommand(dockerCli command.Cli) *cobra.Command {
|
|
var opts saveOptions
|
|
|
|
cmd := &cobra.Command{
|
|
Use: "save [OPTIONS] IMAGE [IMAGE...]",
|
|
Short: "Save one or more images to a tar archive (streamed to STDOUT by default)",
|
|
Args: cli.RequiresMinArgs(1),
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
opts.images = args
|
|
return runSave(cmd.Context(), dockerCli, opts)
|
|
},
|
|
Annotations: map[string]string{
|
|
"aliases": "docker image save, docker save",
|
|
},
|
|
ValidArgsFunction: completion.ImageNames(dockerCli, -1),
|
|
}
|
|
|
|
flags := cmd.Flags()
|
|
|
|
flags.StringVarP(&opts.output, "output", "o", "", "Write to a file, instead of STDOUT")
|
|
flags.StringVar(&opts.platform, "platform", "", `Save only the given platform variant. Formatted as "os[/arch[/variant]]" (e.g., "linux/amd64")`)
|
|
_ = flags.SetAnnotation("platform", "version", []string{"1.48"})
|
|
|
|
_ = cmd.RegisterFlagCompletionFunc("platform", completion.Platforms)
|
|
return cmd
|
|
}
|
|
|
|
// runSave performs a save against the engine based on the specified options
|
|
func runSave(ctx context.Context, dockerCLI command.Cli, opts saveOptions) error {
|
|
var options []client.ImageSaveOption
|
|
if opts.platform != "" {
|
|
p, err := platforms.Parse(opts.platform)
|
|
if err != nil {
|
|
return errors.Wrap(err, "invalid platform")
|
|
}
|
|
// TODO(thaJeztah): change flag-type to support multiple platforms.
|
|
options = append(options, client.ImageSaveWithPlatforms(p))
|
|
}
|
|
|
|
var output io.Writer
|
|
if opts.output == "" {
|
|
if dockerCLI.Out().IsTerminal() {
|
|
return errors.New("cowardly refusing to save to a terminal. Use the -o flag or redirect")
|
|
}
|
|
output = dockerCLI.Out()
|
|
} else {
|
|
writer, err := atomicwriter.New(opts.output, 0o600)
|
|
if err != nil {
|
|
return errors.Wrap(err, "failed to save image")
|
|
}
|
|
defer writer.Close()
|
|
output = writer
|
|
}
|
|
|
|
responseBody, err := dockerCLI.Client().ImageSave(ctx, opts.images, options...)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer responseBody.Close()
|
|
|
|
_, err = io.Copy(output, responseBody)
|
|
return err
|
|
}
|