Same functionality, but implemented with atomicwriter. There's a slight difference in error-messages produced (but can be adjusted if we want). Before: docker container export -o ./no/such/foo mycontainer failed to export container: invalid output path: directory "no/such" does not exist docker container export -o /no/permissions mycontainer failed to export container: stat /no/permissions: permission denied After: docker container export -o ./no/such/foo mycontainer failed to export container: invalid file path: stat no/such: no such file or directory docker container export -o /no/permissions mycontainer failed to export container: failed to stat output path: lstat /no/permissions: permission denied Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
48 lines
1.2 KiB
Go
48 lines
1.2 KiB
Go
package container
|
|
|
|
import (
|
|
"io"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/docker/cli/internal/test"
|
|
"gotest.tools/v3/assert"
|
|
"gotest.tools/v3/fs"
|
|
)
|
|
|
|
func TestContainerExportOutputToFile(t *testing.T) {
|
|
dir := fs.NewDir(t, "export-test")
|
|
defer dir.Remove()
|
|
|
|
cli := test.NewFakeCli(&fakeClient{
|
|
containerExportFunc: func(container string) (io.ReadCloser, error) {
|
|
return io.NopCloser(strings.NewReader("bar")), nil
|
|
},
|
|
})
|
|
cmd := NewExportCommand(cli)
|
|
cmd.SetOut(io.Discard)
|
|
cmd.SetArgs([]string{"-o", dir.Join("foo"), "container"})
|
|
assert.NilError(t, cmd.Execute())
|
|
|
|
expected := fs.Expected(t,
|
|
fs.WithFile("foo", "bar", fs.MatchAnyFileMode),
|
|
)
|
|
|
|
assert.Assert(t, fs.Equal(dir.Path(), expected))
|
|
}
|
|
|
|
func TestContainerExportOutputToIrregularFile(t *testing.T) {
|
|
cli := test.NewFakeCli(&fakeClient{
|
|
containerExportFunc: func(container string) (io.ReadCloser, error) {
|
|
return io.NopCloser(strings.NewReader("foo")), nil
|
|
},
|
|
})
|
|
cmd := NewExportCommand(cli)
|
|
cmd.SetOut(io.Discard)
|
|
cmd.SetErr(io.Discard)
|
|
cmd.SetArgs([]string{"-o", "/dev/random", "container"})
|
|
|
|
const expected = `failed to export container: cannot write to a character device file`
|
|
assert.Error(t, cmd.Execute(), expected)
|
|
}
|