From e569b9f74a60971e074e84cdf12fdc85b2d94cdb Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Tue, 18 Feb 2025 09:28:55 +0100 Subject: [PATCH] cli/internal/oauth: don't use naked returns (nakedret) cli/internal/oauth/jwt.go:62:3: naked return in func `GetClaims` with 9 lines of code (nakedret) return ^ cli/internal/oauth/jwt.go:67:2: naked return in func `GetClaims` with 9 lines of code (nakedret) return ^ Signed-off-by: Sebastiaan van Stijn --- cli/internal/oauth/jwt.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/cli/internal/oauth/jwt.go b/cli/internal/oauth/jwt.go index 87ad1024e9..437ef42569 100644 --- a/cli/internal/oauth/jwt.go +++ b/cli/internal/oauth/jwt.go @@ -56,15 +56,19 @@ type Source struct { } // GetClaims returns claims from an access token without verification. -func GetClaims(accessToken string) (claims Claims, err error) { +func GetClaims(accessToken string) (Claims, error) { token, err := parseSigned(accessToken) if err != nil { - return + return Claims{}, err } + var claims Claims err = token.UnsafeClaimsWithoutVerification(&claims) + if err != nil { + return Claims{}, err + } - return + return claims, nil } // allowedSignatureAlgorithms is a list of allowed signature algorithms for JWTs.