From dd617b1464b7b7858ed7e85d491cb82e2ffeee3d Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Sun, 2 Mar 2025 12:56:47 +0100 Subject: [PATCH] cli/command/trust: remove unused passphrase-retriever from test The test only validates that an error is produced because the notary server is offline, and does not sent a passphrase. Signed-off-by: Sebastiaan van Stijn --- cli/trust/trust_test.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/cli/trust/trust_test.go b/cli/trust/trust_test.go index 771b4291df..836ed3892f 100644 --- a/cli/trust/trust_test.go +++ b/cli/trust/trust_test.go @@ -6,7 +6,6 @@ import ( "github.com/distribution/reference" "github.com/opencontainers/go-digest" "github.com/theupdateframework/notary/client" - "github.com/theupdateframework/notary/passphrase" "github.com/theupdateframework/notary/trustpinning" "gotest.tools/v3/assert" is "gotest.tools/v3/assert/cmp" @@ -47,9 +46,9 @@ func TestGetDigest(t *testing.T) { } func TestGetSignableRolesError(t *testing.T) { - notaryRepo, err := client.NewFileCachedRepository(t.TempDir(), "gun", "https://localhost", nil, passphrase.ConstantRetriever("password"), trustpinning.TrustPinConfig{}) + notaryRepo, err := client.NewFileCachedRepository(t.TempDir(), "gun", "https://localhost", nil, nil, trustpinning.TrustPinConfig{}) assert.NilError(t, err) - target := client.Target{} - _, err = GetSignableRoles(notaryRepo, &target) - assert.Error(t, err, "client is offline") + _, err = GetSignableRoles(notaryRepo, &client.Target{}) + const expected = "client is offline" + assert.Error(t, err, expected) }