1berry/docker-cli
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cli/command/volume: TestVolumeCreateWithFlags: minor fixes

Browse Source 
- assert unhandled error
- reset command-args to prevent test failing when running from pre-compiled test-binary
- use a const and a slightly more unique name for the volume-name
- discard stdout/stderr output

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2025-02-01 14:06:05 +01:00
parent 8b5e5539e1
commit a8265e72bf
No known key found for this signature in database
GPG Key ID: 76698F39D527CE8C
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
cli/command/volume/create_test.go
View File

@ -104,7 +104,8 @@ func TestVolumeCreateWithName(t *testing.T) {
} }
func TestVolumeCreateWithFlags(t *testing.T) { func TestVolumeCreateWithFlags(t *testing.T) {
expectedDriver := "foo" const name = "random-generated-name"
const expectedDriver = "foo-volume-driver"
expectedOpts := map[string]string{ expectedOpts := map[string]string{
"bar": "1", "bar": "1",
"baz": "baz", "baz": "baz",
@ -113,7 +114,6 @@ func TestVolumeCreateWithFlags(t *testing.T) {
"lbl1": "v1", "lbl1": "v1",
"lbl2": "v2", "lbl2": "v2",
} }
name := "banana"
cli := test.NewFakeCli(&fakeClient{ cli := test.NewFakeCli(&fakeClient{
volumeCreateFunc: func(body volume.CreateOptions) (volume.Volume, error) { volumeCreateFunc: func(body volume.CreateOptions) (volume.Volume, error) {
@ -136,13 +136,16 @@ func TestVolumeCreateWithFlags(t *testing.T) {
}) })
cmd := newCreateCommand(cli) cmd := newCreateCommand(cli)
cmd.Flags().Set("driver", "foo") cmd.SetOut(io.Discard)
cmd.Flags().Set("opt", "bar=1") cmd.SetErr(io.Discard)
cmd.Flags().Set("opt", "baz=baz") cmd.SetArgs([]string{})
cmd.Flags().Set("label", "lbl1=v1") assert.Check(t, cmd.Flags().Set("driver", expectedDriver))
cmd.Flags().Set("label", "lbl2=v2") assert.Check(t, cmd.Flags().Set("opt", "bar=1"))
assert.Check(t, cmd.Flags().Set("opt", "baz=baz"))
assert.Check(t, cmd.Flags().Set("label", "lbl1=v1"))
assert.Check(t, cmd.Flags().Set("label", "lbl2=v2"))
assert.NilError(t, cmd.Execute()) assert.NilError(t, cmd.Execute())
assert.Check(t, is.Equal(name, strings.TrimSpace(cli.OutBuffer().String()))) assert.Check(t, is.Equal(strings.TrimSpace(cli.OutBuffer().String()), name))
} }
func TestVolumeCreateCluster(t *testing.T) { func TestVolumeCreateCluster(t *testing.T) {