1berry/docker-cli
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

completion: remove generic "os-only" for platforms

Browse Source 
Using `--platform=linux` or `--platform=windows` is not commonly
used (or recommended). Let's remove these from the list of suggested
platforms.

We should tweak this completion further, and sort the list based
on the daemon's platform (putting linux first for a Linux daemon,
and windows first on a Windows daemon), possibly with the correct
architecture (and os-version) included, but we don't yet provide
that information in `/_ping`.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2025-04-16 11:30:26 +02:00
parent 219d3fe25a
commit 557d721299
No known key found for this signature in database
GPG Key ID: 76698F39D527CE8C
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cli/command/completion/functions.go
View File

@ -152,7 +152,6 @@ func NoComplete(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCo
} }
var commonPlatforms = []string{ var commonPlatforms = []string{
"linux",
"linux/386", "linux/386",
"linux/amd64", "linux/amd64",
"linux/arm", "linux/arm",
@ -169,10 +168,8 @@ var commonPlatforms = []string{
// Not yet supported // Not yet supported
"linux/riscv64", "linux/riscv64",
"windows",
"windows/amd64", "windows/amd64",
"wasip1",
"wasip1/wasm", "wasip1/wasm",
} }