From 48745da16c0d0ab0809f28da234018e5072ea06e Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Sat, 26 Feb 2022 11:21:00 +0100 Subject: [PATCH] cli/registry/client: remove unused RegistryClient.GetTags() This was added in fd2f1b3b6650b53ed1367b84910e0f81e89220cd as part of the `docker engine` sub-commands, which were deprecated, and removed in 43b2f52d0ca4b57bddd0fd541d8440e1f17fd0a6. This function is not used by anyone, so safe to remove. Signed-off-by: Sebastiaan van Stijn --- cli/command/manifest/client_test.go | 8 -------- cli/registry/client/client.go | 14 -------------- 2 files changed, 22 deletions(-) diff --git a/cli/command/manifest/client_test.go b/cli/command/manifest/client_test.go index c5cb9ea1b6..07967c29ab 100644 --- a/cli/command/manifest/client_test.go +++ b/cli/command/manifest/client_test.go @@ -15,7 +15,6 @@ type fakeRegistryClient struct { getManifestListFunc func(ctx context.Context, ref reference.Named) ([]manifesttypes.ImageManifest, error) mountBlobFunc func(ctx context.Context, source reference.Canonical, target reference.Named) error putManifestFunc func(ctx context.Context, source reference.Named, mf distribution.Manifest) (digest.Digest, error) - getTagsFunc func(ctx context.Context, ref reference.Named) ([]string, error) } func (c *fakeRegistryClient) GetManifest(ctx context.Context, ref reference.Named) (manifesttypes.ImageManifest, error) { @@ -46,11 +45,4 @@ func (c *fakeRegistryClient) PutManifest(ctx context.Context, ref reference.Name return digest.Digest(""), nil } -func (c *fakeRegistryClient) GetTags(ctx context.Context, ref reference.Named) ([]string, error) { - if c.getTagsFunc != nil { - return c.getTagsFunc(ctx, ref) - } - return nil, nil -} - var _ client.RegistryClient = &fakeRegistryClient{} diff --git a/cli/registry/client/client.go b/cli/registry/client/client.go index 4c411b9da6..ba76a34fc8 100644 --- a/cli/registry/client/client.go +++ b/cli/registry/client/client.go @@ -24,7 +24,6 @@ type RegistryClient interface { GetManifestList(ctx context.Context, ref reference.Named) ([]manifesttypes.ImageManifest, error) MountBlob(ctx context.Context, source reference.Canonical, target reference.Named) error PutManifest(ctx context.Context, ref reference.Named, manifest distribution.Manifest) (digest.Digest, error) - GetTags(ctx context.Context, ref reference.Named) ([]string, error) } // NewRegistryClient returns a new RegistryClient with a resolver @@ -123,19 +122,6 @@ func (c *client) PutManifest(ctx context.Context, ref reference.Named, manifest return dgst, errors.Wrapf(err, "failed to put manifest %s", ref) } -func (c *client) GetTags(ctx context.Context, ref reference.Named) ([]string, error) { - repoEndpoint, err := newDefaultRepositoryEndpoint(ref, c.insecureRegistry) - if err != nil { - return nil, err - } - - repo, err := c.getRepositoryForReference(ctx, ref, repoEndpoint) - if err != nil { - return nil, err - } - return repo.Tags(ctx).All(ctx) -} - func (c *client) getRepositoryForReference(ctx context.Context, ref reference.Named, repoEndpoint repositoryEndpoint) (distribution.Repository, error) { repoName, err := reference.WithName(repoEndpoint.Name()) if err != nil {