1berry/docker-cli
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cli/command/trust: fix "usetesting" linting errors

Browse Source 
Also fix some unhandled errors

    cli/debug/debug_test.go:12:3: os.Setenv() could be replaced by t.Setenv() in TestEnable (usetesting)
            os.Setenv("DEBUG", "")
            ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2025-02-17 23:00:13 +01:00
parent aca0bd7757
commit 3e9fa43ef8
No known key found for this signature in database
GPG Key ID: 76698F39D527CE8C
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cli/debug/debug.go
View File

@ -10,14 +10,14 @@ import (
// Enable sets the DEBUG env var to true // Enable sets the DEBUG env var to true
// and makes the logger to log at debug level. // and makes the logger to log at debug level.
func Enable() { func Enable() {
os.Setenv("DEBUG", "1") _ = os.Setenv("DEBUG", "1")
logrus.SetLevel(logrus.DebugLevel) logrus.SetLevel(logrus.DebugLevel)
} }
// Disable sets the DEBUG env var to false // Disable sets the DEBUG env var to false
// and makes the logger to log at info level. // and makes the logger to log at info level.
func Disable() { func Disable() {
os.Setenv("DEBUG", "") _ = os.Setenv("DEBUG", "")
logrus.SetLevel(logrus.InfoLevel) logrus.SetLevel(logrus.InfoLevel)
} }

4
cli/debug/debug_test.go
View File

@ -9,9 +9,9 @@ import (
func TestEnable(t *testing.T) { func TestEnable(t *testing.T) {
defer func() { defer func() {
os.Setenv("DEBUG", "")
logrus.SetLevel(logrus.InfoLevel) logrus.SetLevel(logrus.InfoLevel)
}() }()
t.Setenv("DEBUG", "")
Enable() Enable()
if os.Getenv("DEBUG") != "1" { if os.Getenv("DEBUG") != "1" {
t.Fatalf("expected DEBUG=1, got %s\n", os.Getenv("DEBUG")) t.Fatalf("expected DEBUG=1, got %s\n", os.Getenv("DEBUG"))
@ -22,6 +22,7 @@ func TestEnable(t *testing.T) {
} }
func TestDisable(t *testing.T) { func TestDisable(t *testing.T) {
t.Setenv("DEBUG", "1")
Disable() Disable()
if os.Getenv("DEBUG") != "" { if os.Getenv("DEBUG") != "" {
t.Fatalf("expected DEBUG=\"\", got %s\n", os.Getenv("DEBUG")) t.Fatalf("expected DEBUG=\"\", got %s\n", os.Getenv("DEBUG"))
@ -32,6 +33,7 @@ func TestDisable(t *testing.T) {
} }
func TestEnabled(t *testing.T) { func TestEnabled(t *testing.T) {
t.Setenv("DEBUG", "")
Enable() Enable()
if !IsEnabled() { if !IsEnabled() {
t.Fatal("expected debug enabled, got false") t.Fatal("expected debug enabled, got false")