From 71e525f74fa9469832e7fedf40a4a93030563fe9 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 24 Oct 2019 16:28:51 +0200 Subject: [PATCH] gometalinter: fix configuration The configuration abused "Exclude" to exclude file-paths by filtering on the output, however, the `Skip` option was designed for that, whereas `Exclude` is for matching warnings. An explicit "Skip" was added for "vendor", because even though the vendor directory should already be ignored by the linter, in some situations, it still seemed to warn on issues, so let's explicitly ignore it. Signed-off-by: Sebastiaan van Stijn --- gometalinter.json | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gometalinter.json b/gometalinter.json index a31a6a20ef..647516ae87 100644 --- a/gometalinter.json +++ b/gometalinter.json @@ -2,12 +2,16 @@ "Vendor": true, "Deadline": "2m", "Sort": ["linter", "severity", "path", "line"], - "Exclude": [ + "Skip": [ "cli/compose/schema/bindata.go", "cli/command/stack/kubernetes/api/openapi", "cli/command/stack/kubernetes/api/client", ".*generated.*", - "parameter .* always receives" + "vendor" + ], + "Exclude": [ + "parameter .* always receives", + "_esc(Dir|FS|FSString|FSMustString) is unused" ], "EnableGC": true, "Linters": {