1berry/docker-cli
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cli/command/formatter: fix "unused-receiver" linting

Browse Source 
cli/command/formatter/custom.go:35:7: unused-receiver: method receiver 'c' is not referenced in method's body, consider removing or renaming it as _ (revive)
    func (c SubHeaderContext) Label(name string) string {
          ^
    cli/command/formatter/container_test.go:334: line-length-limit: line is 204 characters, out of limit 200 (revive)
                context:  Context{Format: NewContainerFormat(`table {{truncate .ID 5}}\t{{json .Image}} {{.RunningFor}}/{{title .Status}}/{{pad .Ports 2 2}}.{{upper .Names}} {{lower .Status}}`, false, true)},
    cli/command/formatter/container_test.go:831: line-length-limit: line is 247 characters, out of limit 200 (revive)
                expected: "80/tcp, 80/udp, 1024/tcp, 1024/udp, 12345/sctp, 1.1.1.1:1024->80/tcp, 1.1.1.1:1024->80/udp, 2.1.1.1:1024->80/tcp, 2.1.1.1:1024->80/udp, 1.1.1.1:80->1024/tcp, 1.1.1.1:80->1024/udp, 2.1.1.1:80->1024/tcp, 2.1.1.1:80->1024/udp",
    cli/command/formatter/disk_usage.go:273:7: unused-receiver: method receiver 'c' is not referenced in method's body, consider removing or renaming it as _ (revive)
    func (c *diskUsageImagesContext) Type() string {
          ^
    cli/command/formatter/formatter_test.go:31:7: unused-receiver: method receiver 'f' is not referenced in method's body, consider removing or renaming it as _ (revive)
    func (f fakeSubContext) FullHeader() any {
          ^
    cli/command/formatter/reflect_test.go:13:7: unused-receiver: method receiver 'd' is not referenced in method's body, consider removing or renaming it as _ (revive)
    func (d *dummy) Func1() string {
          ^
    cli/command/formatter/disk_usage.go:324:7: unused-receiver: method receiver 'c' is not referenced in method's body, consider removing or renaming it as _ (revive)
    func (c *diskUsageContainersContext) Type() string {
          ^
    cli/command/formatter/disk_usage.go:332:7: unused-receiver: method receiver 'c' is not referenced in method's body, consider removing or renaming it as _ (revive)
    func (c *diskUsageContainersContext) isActive(ctr container.Summary) bool {
          ^
    cli/command/formatter/reflect_test.go:17:7: unused-receiver: method receiver 'd' is not referenced in method's body, consider removing or renaming it as _ (revive)
    func (d *dummy) func2() string { //nolint:unused
          ^
    cli/command/formatter/reflect_test.go:21:7: unused-receiver: method receiver 'd' is not referenced in method's body, consider removing or renaming it as _ (revive)
    func (d *dummy) Func3() (string, int) {
          ^
    cli/command/formatter/disk_usage.go:385:7: unused-receiver: method receiver 'c' is not referenced in method's body, consider removing or renaming it as _ (revive)
    func (c *diskUsageVolumesContext) Type() string {
          ^
    cli/command/formatter/disk_usage.go:446:7: unused-receiver: method receiver 'c' is not referenced in method's body, consider removing or renaming it as _ (revive)
    func (c *diskUsageBuilderContext) Type() string {
          ^
    cli/command/formatter/reflect_test.go:25:7: unused-receiver: method receiver 'd' is not referenced in method's body, consider removing or renaming it as _ (revive)
    func (d *dummy) Func4() int {
          ^
    cli/command/formatter/reflect_test.go:31:7: unused-receiver: method receiver 'd' is not referenced in method's body, consider removing or renaming it as _ (revive)
    func (d *dummy) Func5() dummyType {
          ^
    cli/command/formatter/reflect_test.go:35:7: unused-receiver: method receiver 'd' is not referenced in method's body, consider removing or renaming it as _ (revive)
    func (d *dummy) FullHeader() string {
          ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2025-02-17 14:14:14 +01:00
parent 450768c311
commit 25e6b2da04
No known key found for this signature in database
GPG Key ID: 76698F39D527CE8C
5 changed files with 21 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
cli/command/formatter/container_test.go
View File

@ -331,7 +331,12 @@ size: 0B
}, },
// Special headers for customized table format // Special headers for customized table format
{ {
context: Context{Format: NewContainerFormat(`table {{truncate .ID 5}}\t{{json .Image}} {{.RunningFor}}/{{title .Status}}/{{pad .Ports 2 2}}.{{upper .Names}} {{lower .Status}}`, false, true)}, context: Context{
Format: NewContainerFormat(
`table {{truncate .ID 5}}\t{{json .Image}} {{.RunningFor}}/{{title .Status}}/{{pad .Ports 2 2}}.{{upper .Names}} {{lower .Status}}`,
false, true,
),
},
expected: string(golden.Get(t, "container-context-write-special-headers.golden")), expected: string(golden.Get(t, "container-context-write-special-headers.golden")),
}, },
{ {
@ -525,7 +530,6 @@ type ports struct {
expected string expected string
} }
//nolint:lll
func TestDisplayablePorts(t *testing.T) { func TestDisplayablePorts(t *testing.T) {
cases := []ports{ cases := []ports{
{ {
@ -828,7 +832,7 @@ func TestDisplayablePorts(t *testing.T) {
Type: "sctp", Type: "sctp",
}, },
}, },
expected: "80/tcp, 80/udp, 1024/tcp, 1024/udp, 12345/sctp, 1.1.1.1:1024->80/tcp, 1.1.1.1:1024->80/udp, 2.1.1.1:1024->80/tcp, 2.1.1.1:1024->80/udp, 1.1.1.1:80->1024/tcp, 1.1.1.1:80->1024/udp, 2.1.1.1:80->1024/tcp, 2.1.1.1:80->1024/udp", expected: "80/tcp, 80/udp, 1024/tcp, 1024/udp, 12345/sctp, 1.1.1.1:1024->80/tcp, 1.1.1.1:1024->80/udp, 2.1.1.1:1024->80/tcp, 2.1.1.1:1024->80/udp, 1.1.1.1:80->1024/tcp, 1.1.1.1:80->1024/udp, 2.1.1.1:80->1024/tcp, 2.1.1.1:80->1024/udp", //nolint:lll,revive // ignore line-length-limit (revive)
}, },
} }

2
cli/command/formatter/custom.go
View File

@ -32,7 +32,7 @@ type SubContext interface {
type SubHeaderContext map[string]string type SubHeaderContext map[string]string
// Label returns the header label for the specified string // Label returns the header label for the specified string
func (c SubHeaderContext) Label(name string) string { func (SubHeaderContext) Label(name string) string {
n := strings.Split(name, ".") n := strings.Split(name, ".")
r := strings.NewReplacer("-", " ", "_", " ") r := strings.NewReplacer("-", " ", "_", " ")
h := r.Replace(n[len(n)-1]) h := r.Replace(n[len(n)-1])

10
cli/command/formatter/disk_usage.go
View File

@ -270,7 +270,7 @@ func (c *diskUsageImagesContext) MarshalJSON() ([]byte, error) {
return MarshalJSON(c) return MarshalJSON(c)
} }
func (c *diskUsageImagesContext) Type() string { func (*diskUsageImagesContext) Type() string {
return "Images" return "Images"
} }
@ -321,7 +321,7 @@ func (c *diskUsageContainersContext) MarshalJSON() ([]byte, error) {
return MarshalJSON(c) return MarshalJSON(c)
} }
func (c *diskUsageContainersContext) Type() string { func (*diskUsageContainersContext) Type() string {
return "Containers" return "Containers"
} }
@ -329,7 +329,7 @@ func (c *diskUsageContainersContext) TotalCount() string {
return strconv.Itoa(len(c.containers)) return strconv.Itoa(len(c.containers))
} }
func (c *diskUsageContainersContext) isActive(ctr container.Summary) bool { func (*diskUsageContainersContext) isActive(ctr container.Summary) bool {
return strings.Contains(ctr.State, "running") || return strings.Contains(ctr.State, "running") ||
strings.Contains(ctr.State, "paused") || strings.Contains(ctr.State, "paused") ||
strings.Contains(ctr.State, "restarting") strings.Contains(ctr.State, "restarting")
@ -382,7 +382,7 @@ func (c *diskUsageVolumesContext) MarshalJSON() ([]byte, error) {
return MarshalJSON(c) return MarshalJSON(c)
} }
func (c *diskUsageVolumesContext) Type() string { func (*diskUsageVolumesContext) Type() string {
return "Local Volumes" return "Local Volumes"
} }
@ -443,7 +443,7 @@ func (c *diskUsageBuilderContext) MarshalJSON() ([]byte, error) {
return MarshalJSON(c) return MarshalJSON(c)
} }
func (c *diskUsageBuilderContext) Type() string { func (*diskUsageBuilderContext) Type() string {
return "Build Cache" return "Build Cache"
} }

2
cli/command/formatter/formatter_test.go
View File

@ -28,7 +28,7 @@ type fakeSubContext struct {
Name string Name string
} }
func (f fakeSubContext) FullHeader() any { func (fakeSubContext) FullHeader() any {
return map[string]string{"Name": "NAME"} return map[string]string{"Name": "NAME"}
} }

14
cli/command/formatter/reflect_test.go
View File

@ -10,29 +10,29 @@ import (
type dummy struct{} type dummy struct{}
func (d *dummy) Func1() string { func (*dummy) Func1() string {
return "Func1" return "Func1"
} }
func (d *dummy) func2() string { //nolint:unused func (*dummy) func2() string { //nolint:unused
return "func2(should not be marshalled)" return "func2(should not be marshalled)"
} }
func (d *dummy) Func3() (string, int) { func (*dummy) Func3() (string, int) {
return "Func3(should not be marshalled)", -42 return "Func3(should not be marshalled)", -42
} }
func (d *dummy) Func4() int { func (*dummy) Func4() int {
return 4 return 4
} }
type dummyType string type dummyType string
func (d *dummy) Func5() dummyType { func (*dummy) Func5() dummyType {
return dummyType("Func5") return "Func5"
} }
func (d *dummy) FullHeader() string { func (*dummy) FullHeader() string {
return "FullHeader(should not be marshalled)" return "FullHeader(should not be marshalled)"
} }