1berry/docker-cli
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

docker service inspect fails when TaskTemplate.Resources is nil

Browse Source 
When doing `docker service inspect --pretty` on services without
`TaskTemplate.Resources` or `TaskTemplate.Resources.Limits`, the command
fails. This is due to a missing check on ResourceLimitPids().

This bug has been introduced by 395a6d560decb1da85ec66b0913a555ceace738d
and produces following error message:

```
Template parsing error: template: :139:10: executing "" at <.ResourceLimitPids>: error calling ResourceLimitPids: runtime error: invalid memory address or nil pointer dereference
```

Signed-off-by: Albin Kerouanton <albin@akerouanton.name>
This commit is contained in:
Albin Kerouanton 2020-07-28 22:11:13 +02:00
parent 12b74cb5a0
commit 21da11c5fd
No known key found for this signature in database
GPG Key ID: 630B8E1DCBDB1864
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cli/command/service/formatter.go
View File

@ -502,6 +502,9 @@ func (ctx *serviceInspectContext) ResourceLimitMemory() string {
}
func (ctx *serviceInspectContext) ResourceLimitPids() int64 {
if ctx.Service.Spec.TaskTemplate.Resources == nil || ctx.Service.Spec.TaskTemplate.Resources.Limits == nil {
return 0
}
return ctx.Service.Spec.TaskTemplate.Resources.Limits.Pids
}