From 1d8f87a2fb2dbe5ca9ea8e956acde7de4cfa5a1b Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Sun, 2 Mar 2025 14:07:03 +0100 Subject: [PATCH] cli/command/trust: remove TestGetSignableRolesForTargetAndRemoveError This test was only testing trust.GetSignableRoles to return an error if it's offline, which was duplicating the [TestGetSignableRolesError] test. [TestGetSignableRolesError]: https://github.com/docker/cli/blob/fe0a8d27912dc6fddc60cedcd35bbef27b776355/cli/trust/trust_test.go#L49-L55 Signed-off-by: Sebastiaan van Stijn --- cli/command/trust/revoke_test.go | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/cli/command/trust/revoke_test.go b/cli/command/trust/revoke_test.go index 6e2ebd66bf..da1e48ecf8 100644 --- a/cli/command/trust/revoke_test.go +++ b/cli/command/trust/revoke_test.go @@ -9,8 +9,6 @@ import ( "github.com/docker/cli/internal/test" "github.com/docker/cli/internal/test/notary" "github.com/theupdateframework/notary/client" - "github.com/theupdateframework/notary/passphrase" - "github.com/theupdateframework/notary/trustpinning" "gotest.tools/v3/assert" is "gotest.tools/v3/assert/cmp" "gotest.tools/v3/golden" @@ -151,14 +149,6 @@ func TestTrustRevokeCommand(t *testing.T) { } } -func TestGetSignableRolesForTargetAndRemoveError(t *testing.T) { - notaryRepo, err := client.NewFileCachedRepository(t.TempDir(), "gun", "https://localhost", nil, passphrase.ConstantRetriever("password"), trustpinning.TrustPinConfig{}) - assert.NilError(t, err) - target := client.Target{} - err = getSignableRolesForTargetAndRemove(target, notaryRepo) - assert.Error(t, err, "client is offline") -} - func TestRevokeTrustPromptTermination(t *testing.T) { ctx, cancel := context.WithCancel(context.Background()) t.Cleanup(cancel)