address review comments

mysql-test/collections/README.experimental

@@ -11,7 +11,7 @@ The syntax is as follows:
 
 2) Empty lines and lines starting with a hash (#) are ignored.
 
-3) If any other line contains a black followed by a hash (#), the hash 
+3) If any other line contains a blank followed by a hash (#), the hash 
    and any subsequent characters are ignored.
 
 4) The full test case name including the suite and execution mode

mysql-test/lib/mtr_report.pm

@@ -109,10 +109,10 @@ sub mtr_report_test ($) {
   my ($tinfo)= @_;
   my $test_name = _mtr_report_test_name($tinfo);
 
-  my $comment=      $tinfo->{'comment'};
+  my $comment=  $tinfo->{'comment'};
-  my $logfile=      $tinfo->{'logfile'};
+  my $logfile=  $tinfo->{'logfile'};
-  my $warnings=     $tinfo->{'warnings'};
+  my $warnings= $tinfo->{'warnings'};
-  my $result=       $tinfo->{'result'};
+  my $result=   $tinfo->{'result'};
 
   if ($result eq 'MTR_RES_FAILED'){
 
@@ -123,14 +123,20 @@ sub mtr_report_test ($) {
     {
       # Find out if this test case is an experimental one, so we can treat
       # the failure as an expected failure instead of a regression.
-      for my $exp ( @$::opt_experimental ) {
+      for my $exp ( @$::experimental_test_cases ) {
         if ( $exp ne $test_name ) {
+          # if the expression is not the name of this test case, but has
+          # an asterisk at the end, determine if the characters up to
+          # but excluding the asterisk are the same
           if ( $exp ne "" && substr($exp, -1, 1) eq "*" ) {
             $exp = substr($exp, 0, length($exp) - 1);
             if ( substr($test_name, 0, length($exp)) ne $exp ) {
+              # no match, try next entry
               next;
             }
+            # if yes, fall through to set the exp-fail status
           } else {
+            # no match, try next entry
             next;
           }
         }

mysql-test/mysql-test-run.pl

@@ -170,6 +170,7 @@ my $config; # The currently running config
 my $current_config_name; # The currently running config file template
 
 our $opt_experimental;
+our $experimental_test_cases;
 
 my $baseport;
 my $opt_build_thread= $ENV{'MTR_BUILD_THREAD'} || "auto";
@@ -963,24 +964,29 @@ sub command_line_setup {
 
   if ( $opt_experimental )
   {
-    if ( open(FILE, "<", $opt_experimental) ) {
+    # read the list of experimental test cases from the file specified on
-      mtr_report("Using experimental file: $opt_experimental");
+    # the command line
-      $opt_experimental = [];
+    open(FILE, "<", $opt_experimental) or mtr_error("Can't read experimental file: $opt_experimental");
-      while(<FILE>) {
+    mtr_report("Using experimental file: $opt_experimental");
-        chomp;
+    $experimental_test_cases = [];
-        s/( +|^)#.*$//;
+    while(<FILE>) {
-        s/^ +//;
+      chomp;
-        s/ +$//;
+      # remove comments (# foo) at the beginning of the line, or after a 
-        if ( $_ eq "" ) {
+      # blank at the end of the line
-          next;
+      s/( +|^)#.*$//;
-        }
+      # remove whitespace
-        print " - $_\n";
+      s/^ +//;              
-        push @$opt_experimental, $_;
+      s/ +$//;
+      # if nothing left, don't need to remember this line
+      if ( $_ eq "" ) {
+        next;
       }
-      close FILE;
+      # remember what is left as the name of another test case that should be
-    } else {
+      # treated as experimental
-      mtr_error("Can't read experimental file: $opt_experimental");      
+      print " - $_\n";
+      push @$experimental_test_cases, $_;
     }
+    close FILE;
   }
 
   foreach my $arg ( @ARGV )