1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merging from mysql-5.1-security

Browse Source
This commit is contained in:
Alexander Barkov 2010-11-12 13:20:58 +03:00
commit efe8743bd8
3 changed files with 37 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
mysql-test/r/date_formats.result
View File

@ -544,3 +544,17 @@ SELECT DATE_FORMAT("2009-01-01",'%W %d %M %Y') as valid_date;
valid_date valid_date
Thursday 01 January 2009 Thursday 01 January 2009
"End of 5.0 tests" "End of 5.0 tests"
#
# Start of 5.1 tests
#
#
# Bug#58005 utf8 + get_format causes failed assertion: !str || str != Ptr'
#
SET NAMES utf8;
SELECT LEAST('%', GET_FORMAT(datetime, 'eur'), CAST(GET_FORMAT(datetime, 'eur') AS CHAR(65535)));
LEAST('%', GET_FORMAT(datetime, 'eur'), CAST(GET_FORMAT(datetime, 'eur') AS CHAR(65535)))
%
SET NAMES latin1;
#
# End of 5.1 tests
#

16
mysql-test/t/date_formats.test
View File

@ -354,3 +354,19 @@ SELECT DATE_FORMAT("0000-02-28",'%W %d %M %Y') as valid_date;
SELECT DATE_FORMAT("2009-01-01",'%W %d %M %Y') as valid_date; SELECT DATE_FORMAT("2009-01-01",'%W %d %M %Y') as valid_date;
--echo "End of 5.0 tests" --echo "End of 5.0 tests"
--echo #
--echo # Start of 5.1 tests
--echo #
--echo #
--echo # Bug#58005 utf8 + get_format causes failed assertion: !str || str != Ptr'
--echo #
SET NAMES utf8;
SELECT LEAST('%', GET_FORMAT(datetime, 'eur'), CAST(GET_FORMAT(datetime, 'eur') AS CHAR(65535)));
SET NAMES latin1;
--echo #
--echo # End of 5.1 tests
--echo #

14
sql/item_timefunc.cc
View File

@ -2526,14 +2526,14 @@ String *Item_char_typecast::val_str(String *str)
{ {
// Convert character set if differ // Convert character set if differ
uint dummy_errors; uint dummy_errors;
if (!(res= args[0]->val_str(&tmp_value)) || if (!(res= args[0]->val_str(str)) ||
str->copy(res->ptr(), res->length(), from_cs, tmp_value.copy(res->ptr(), res->length(), from_cs,
cast_cs, &dummy_errors)) cast_cs, &dummy_errors))
{ {
null_value= 1; null_value= 1;
return 0; return 0;
} }
res= str; res= &tmp_value;
} }
res->set_charset(cast_cs); res->set_charset(cast_cs);
@ -2568,9 +2568,9 @@ String *Item_char_typecast::val_str(String *str)
{ {
if (res->alloced_length() < (uint) cast_length) if (res->alloced_length() < (uint) cast_length)
{ {
str->alloc(cast_length); str_value.alloc(cast_length);
str->copy(*res); str_value.copy(*res);
res= str; res= &str_value;
} }
bzero((char*) res->ptr() + res->length(), bzero((char*) res->ptr() + res->length(),
(uint) cast_length - res->length()); (uint) cast_length - res->length());