From 4ecf51112a1b49c28717908d556774f7100067ca Mon Sep 17 00:00:00 2001 From: unknown Date: Fri, 24 Sep 2004 18:25:06 +0200 Subject: [PATCH] In binary log events, flags are 2 bytes, not 4. Using 4 resulted in buffer overflow (and on a certain build it resulted in overwriting another part of the event without crashing :( ). sql/log_event.cc: flags are 2 bytes, not 4. Using 4 resulted in buffer overflow (and on a certain build it resulted in overwriting another part of the event without crashing :( ). --- sql/log_event.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql/log_event.cc b/sql/log_event.cc index 0e130158919..01dcb2af21c 100644 --- a/sql/log_event.cc +++ b/sql/log_event.cc @@ -571,7 +571,7 @@ bool Log_event::write_header(IO_CACHE* file, ulong event_data_length) int4store(header+ SERVER_ID_OFFSET, server_id); int4store(header+ EVENT_LEN_OFFSET, data_written); int4store(header+ LOG_POS_OFFSET, log_pos); - int4store(header+ FLAGS_OFFSET, flags); + int2store(header+ FLAGS_OFFSET, flags); DBUG_RETURN(my_b_safe_write(file, header, sizeof(header)) != 0); }