From dc23a9501a995d7b24c98877fbdf40435ad1a097 Mon Sep 17 00:00:00 2001 From: Sergei Golubchik Date: Thu, 1 May 2014 14:05:52 +0200 Subject: [PATCH] Solaris compilation failure: xtradb is linked in statically, ha_innodb.so needs the linker script. --- storage/innobase/CMakeLists.txt | 10 ++++++++++ storage/{xtradb => innobase}/plugin_exports | 0 storage/xtradb/CMakeLists.txt | 10 ---------- 3 files changed, 10 insertions(+), 10 deletions(-) rename storage/{xtradb => innobase}/plugin_exports (100%) diff --git a/storage/innobase/CMakeLists.txt b/storage/innobase/CMakeLists.txt index 8210115fb82..50fdb36495d 100644 --- a/storage/innobase/CMakeLists.txt +++ b/storage/innobase/CMakeLists.txt @@ -391,6 +391,16 @@ IF(WITH_INNODB) SET(WITH_INNOBASE_STORAGE_ENGINE TRUE) ENDIF() +# On solaris, reduce symbol visibility, so loader does not mix +# the same symbols from builtin innodb and from shared one. +# Only required for old GCC (3.4.3) that does not support hidden visibility +IF(CMAKE_SYSTEM_NAME MATCHES "SunOS" AND CMAKE_COMPILER_IS_GNUCC + AND NOT HAVE_VISIBILITY_HIDDEN) + SET(LINKER_SCRIPT "-Wl,-M${CMAKE_CURRENT_SOURCE_DIR}/plugin_exports") +ELSE() + SET(LINKER_SCRIPT) +ENDIF() + MYSQL_ADD_PLUGIN(innobase ${INNOBASE_SOURCES} STORAGE_ENGINE MODULE_ONLY MODULE_OUTPUT_NAME ha_innodb diff --git a/storage/xtradb/plugin_exports b/storage/innobase/plugin_exports similarity index 100% rename from storage/xtradb/plugin_exports rename to storage/innobase/plugin_exports diff --git a/storage/xtradb/CMakeLists.txt b/storage/xtradb/CMakeLists.txt index a8b2c405eab..b3751b269c3 100644 --- a/storage/xtradb/CMakeLists.txt +++ b/storage/xtradb/CMakeLists.txt @@ -400,16 +400,6 @@ IF(WITH_INNODB) SET(WITH_INNOBASE_STORAGE_ENGINE TRUE) ENDIF() -# On solaris, reduce symbol visibility, so loader does not mix -# the same symbols from builtin innodb and from shared one. -# Only required for old GCC (3.4.3) that does not support hidden visibility -IF(CMAKE_SYSTEM_NAME MATCHES "SunOS" AND CMAKE_COMPILER_IS_GNUCC - AND NOT HAVE_VISIBILITY_HIDDEN) - SET(LINKER_SCRIPT "-Wl,-M${CMAKE_CURRENT_SOURCE_DIR}/plugin_exports") -ELSE() - SET(LINKER_SCRIPT) -ENDIF() - IF(XTRADB_OK) MYSQL_ADD_PLUGIN(xtradb ${INNOBASE_SOURCES} STORAGE_ENGINE DEFAULT