From e167837a6325c388ecc09fb0ecbfbfac7d84a8a5 Mon Sep 17 00:00:00 2001 From: unknown Date: Fri, 7 Jan 2005 14:17:08 -0600 Subject: [PATCH 1/5] set_var.cc: Reorder variables to properly alphabetize SHOW VARIABLES output. sql/set_var.cc: Reorder variables to properly alphabetize SHOW VARIABLES output. --- sql/set_var.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sql/set_var.cc b/sql/set_var.cc index 082c55db188..2a5242ece7e 100644 --- a/sql/set_var.cc +++ b/sql/set_var.cc @@ -711,11 +711,11 @@ struct show_var_st init_vars[]= { {"innodb_fast_shutdown", (char*) &innobase_fast_shutdown, SHOW_MY_BOOL}, {"innodb_file_io_threads", (char*) &innobase_file_io_threads, SHOW_LONG }, {"innodb_file_per_table", (char*) &innobase_file_per_table, SHOW_MY_BOOL}, - {"innodb_locks_unsafe_for_binlog", (char*) &innobase_locks_unsafe_for_binlog, SHOW_MY_BOOL}, {"innodb_flush_log_at_trx_commit", (char*) &innobase_flush_log_at_trx_commit, SHOW_INT}, {"innodb_flush_method", (char*) &innobase_unix_file_flush_method, SHOW_CHAR_PTR}, {"innodb_force_recovery", (char*) &innobase_force_recovery, SHOW_LONG }, {"innodb_lock_wait_timeout", (char*) &innobase_lock_wait_timeout, SHOW_LONG }, + {"innodb_locks_unsafe_for_binlog", (char*) &innobase_locks_unsafe_for_binlog, SHOW_MY_BOOL}, {"innodb_log_arch_dir", (char*) &innobase_log_arch_dir, SHOW_CHAR_PTR}, {"innodb_log_archive", (char*) &innobase_log_archive, SHOW_MY_BOOL}, {"innodb_log_buffer_size", (char*) &innobase_log_buffer_size, SHOW_LONG }, @@ -724,10 +724,10 @@ struct show_var_st init_vars[]= { {"innodb_log_group_home_dir", (char*) &innobase_log_group_home_dir, SHOW_CHAR_PTR}, {sys_innodb_max_dirty_pages_pct.name, (char*) &sys_innodb_max_dirty_pages_pct, SHOW_SYS}, {sys_innodb_max_purge_lag.name, (char*) &sys_innodb_max_purge_lag, SHOW_SYS}, - {sys_innodb_table_locks.name, (char*) &sys_innodb_table_locks, SHOW_SYS}, {sys_innodb_max_purge_lag.name, (char*) &sys_innodb_max_purge_lag, SHOW_SYS}, {"innodb_mirrored_log_groups", (char*) &innobase_mirrored_log_groups, SHOW_LONG}, {"innodb_open_files", (char*) &innobase_open_files, SHOW_LONG }, + {sys_innodb_table_locks.name, (char*) &sys_innodb_table_locks, SHOW_SYS}, {"innodb_thread_concurrency", (char*) &innobase_thread_concurrency, SHOW_LONG }, #endif {sys_interactive_timeout.name,(char*) &sys_interactive_timeout, SHOW_SYS}, From 895b50d74c772eac555faa69521c3a976a85d1e9 Mon Sep 17 00:00:00 2001 From: unknown Date: Sat, 8 Jan 2005 07:31:13 +0100 Subject: [PATCH 2/5] Use 'USING ' in results of SHOW CREATE TABLE, it's the preferred syntax. (Bug #7233) sql/sql_show.cc: Use 'USING ' in SHOW CREATE TABLE, it's the preferred syntax mysql-test/r/ctype_utf8.result: Update results mysql-test/r/show_check.result: Update results mysql-test/r/sql_mode.result: Update results mysql-test/t/show_check.test: Use preferred syntax 'USING BTREE' instead of 'TYPE BTREE' --- mysql-test/r/ctype_utf8.result | 4 ++-- mysql-test/r/show_check.result | 4 ++-- mysql-test/r/sql_mode.result | 6 +++--- mysql-test/t/show_check.test | 4 ++-- sql/sql_show.cc | 4 ++-- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/mysql-test/r/ctype_utf8.result b/mysql-test/r/ctype_utf8.result index 599d49208e7..41e2c13a4b5 100644 --- a/mysql-test/r/ctype_utf8.result +++ b/mysql-test/r/ctype_utf8.result @@ -448,7 +448,7 @@ show create table t1; Table Create Table t1 CREATE TABLE `t1` ( `c` char(10) character set utf8 default NULL, - UNIQUE KEY `a` TYPE BTREE (`c`(1)) + UNIQUE KEY `a` USING BTREE (`c`(1)) ) ENGINE=HEAP DEFAULT CHARSET=latin1 insert into t1 values ('a'),('b'),('c'),('d'),('e'),('f'); insert into t1 values ('aa'); @@ -606,7 +606,7 @@ show create table t1; Table Create Table t1 CREATE TABLE `t1` ( `c` char(10) character set utf8 collate utf8_bin default NULL, - UNIQUE KEY `a` TYPE BTREE (`c`(1)) + UNIQUE KEY `a` USING BTREE (`c`(1)) ) ENGINE=HEAP DEFAULT CHARSET=latin1 insert into t1 values ('a'),('b'),('c'),('d'),('e'),('f'); insert into t1 values ('aa'); diff --git a/mysql-test/r/show_check.result b/mysql-test/r/show_check.result index 0afe45eb5e5..7d214e2da05 100644 --- a/mysql-test/r/show_check.result +++ b/mysql-test/r/show_check.result @@ -297,7 +297,7 @@ select @@max_heap_table_size; 1047552 CREATE TABLE t1 ( a int(11) default NULL, -KEY a TYPE BTREE (a) +KEY a USING BTREE (a) ) ENGINE=HEAP; CREATE TABLE t2 ( b int(11) default NULL, @@ -306,7 +306,7 @@ index(b) CREATE TABLE t3 ( a int(11) default NULL, b int(11) default NULL, -KEY a TYPE BTREE (a), +KEY a USING BTREE (a), index(b) ) ENGINE=HEAP; insert into t1 values (1),(2); diff --git a/mysql-test/r/sql_mode.result b/mysql-test/r/sql_mode.result index c18be2df403..e0bbc0f2148 100644 --- a/mysql-test/r/sql_mode.result +++ b/mysql-test/r/sql_mode.result @@ -17,7 +17,7 @@ t1 CREATE TABLE `t1` ( `pseudo` varchar(35) character set latin2 NOT NULL default '', `email` varchar(60) character set latin2 NOT NULL default '', PRIMARY KEY (`a`), - UNIQUE KEY `email` TYPE BTREE (`email`) + UNIQUE KEY `email` USING BTREE (`email`) ) ENGINE=HEAP DEFAULT CHARSET=latin1 ROW_FORMAT=DYNAMIC set @@sql_mode="ansi_quotes"; show variables like 'sql_mode'; @@ -30,7 +30,7 @@ t1 CREATE TABLE "t1" ( "pseudo" varchar(35) character set latin2 NOT NULL default '', "email" varchar(60) character set latin2 NOT NULL default '', PRIMARY KEY ("a"), - UNIQUE KEY "email" TYPE BTREE ("email") + UNIQUE KEY "email" USING BTREE ("email") ) ENGINE=HEAP DEFAULT CHARSET=latin1 ROW_FORMAT=DYNAMIC set @@sql_mode="no_table_options"; show variables like 'sql_mode'; @@ -43,7 +43,7 @@ t1 CREATE TABLE `t1` ( `pseudo` varchar(35) character set latin2 NOT NULL default '', `email` varchar(60) character set latin2 NOT NULL default '', PRIMARY KEY (`a`), - UNIQUE KEY `email` TYPE BTREE (`email`) + UNIQUE KEY `email` USING BTREE (`email`) ) set @@sql_mode="no_key_options"; show variables like 'sql_mode'; diff --git a/mysql-test/t/show_check.test b/mysql-test/t/show_check.test index 7788215dd27..3bbfe862361 100644 --- a/mysql-test/t/show_check.test +++ b/mysql-test/t/show_check.test @@ -210,7 +210,7 @@ select @@max_heap_table_size; CREATE TABLE t1 ( a int(11) default NULL, - KEY a TYPE BTREE (a) + KEY a USING BTREE (a) ) ENGINE=HEAP; CREATE TABLE t2 ( @@ -221,7 +221,7 @@ CREATE TABLE t2 ( CREATE TABLE t3 ( a int(11) default NULL, b int(11) default NULL, - KEY a TYPE BTREE (a), + KEY a USING BTREE (a), index(b) ) ENGINE=HEAP; diff --git a/sql/sql_show.cc b/sql/sql_show.cc index ba13dd1ff04..142badeb85c 100644 --- a/sql/sql_show.cc +++ b/sql/sql_show.cc @@ -1408,12 +1408,12 @@ store_create_info(THD *thd, TABLE *table, String *packet) { if (table->db_type == DB_TYPE_HEAP && key_info->algorithm == HA_KEY_ALG_BTREE) - packet->append(" TYPE BTREE", 11); + packet->append(" USING BTREE", 12); // +BAR: send USING only in non-default case: non-spatial rtree if ((key_info->algorithm == HA_KEY_ALG_RTREE) && !(key_info->flags & HA_SPATIAL)) - packet->append(" TYPE RTREE", 11); + packet->append(" USING RTREE", 12); } packet->append(" (", 2); From e9befed6449ec745c5fe14891c2491ae14f38dfd Mon Sep 17 00:00:00 2001 From: unknown Date: Sat, 8 Jan 2005 23:32:28 +0100 Subject: [PATCH 3/5] Update test as result of merge mysql-test/r/heap.result: update test --- mysql-test/r/heap.result | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mysql-test/r/heap.result b/mysql-test/r/heap.result index bcdb24668bb..50f6d3d56fc 100644 --- a/mysql-test/r/heap.result +++ b/mysql-test/r/heap.result @@ -556,9 +556,9 @@ t1 CREATE TABLE `t1` ( `v` varchar(10) default NULL, `c` char(10) default NULL, `t` varchar(50) default NULL, - KEY `v` TYPE BTREE (`v`), - KEY `c` TYPE BTREE (`c`), - KEY `t` TYPE BTREE (`t`(10)) + KEY `v` USING BTREE (`v`), + KEY `c` USING BTREE (`c`), + KEY `t` USING BTREE (`t`(10)) ) ENGINE=HEAP DEFAULT CHARSET=latin1 select count(*) from t1; count(*) From c6f3edbe887df2472119b5e15ad7d060d87b0035 Mon Sep 17 00:00:00 2001 From: unknown Date: Sat, 8 Jan 2005 19:40:58 -0600 Subject: [PATCH 4/5] sql_select.cc: silence picky compiler warning. sql/sql_select.cc: silence picky compiler warning. --- sql/sql_select.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql/sql_select.cc b/sql/sql_select.cc index a44628d66a9..b9c8f6c1237 100644 --- a/sql/sql_select.cc +++ b/sql/sql_select.cc @@ -7904,7 +7904,7 @@ create_tmp_table(THD *thd,TMP_TABLE_PARAM *param,List &fields, table->s->keys_for_keyread.init(); table->s->keys_in_use.init(); /* For easier error reporting */ - table->s->table_cache_key= (char*) table->s->db= ""; + table->s->table_cache_key= (char*) (table->s->db= ""); /* Calculate which type of fields we will store in the temporary table */ From f8f7888b5ce63d363907d3ddb66b9900af92cd10 Mon Sep 17 00:00:00 2001 From: unknown Date: Sat, 8 Jan 2005 19:43:15 -0600 Subject: [PATCH 5/5] set_var.cc: Whack duplicate variable line. (Affects SHOW VARIABLES.) sql/set_var.cc: Whack duplicate variable line. (Affects SHOW VARIABLES.) --- sql/set_var.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/sql/set_var.cc b/sql/set_var.cc index 2a5242ece7e..e44ac742abe 100644 --- a/sql/set_var.cc +++ b/sql/set_var.cc @@ -724,7 +724,6 @@ struct show_var_st init_vars[]= { {"innodb_log_group_home_dir", (char*) &innobase_log_group_home_dir, SHOW_CHAR_PTR}, {sys_innodb_max_dirty_pages_pct.name, (char*) &sys_innodb_max_dirty_pages_pct, SHOW_SYS}, {sys_innodb_max_purge_lag.name, (char*) &sys_innodb_max_purge_lag, SHOW_SYS}, - {sys_innodb_max_purge_lag.name, (char*) &sys_innodb_max_purge_lag, SHOW_SYS}, {"innodb_mirrored_log_groups", (char*) &innobase_mirrored_log_groups, SHOW_LONG}, {"innodb_open_files", (char*) &innobase_open_files, SHOW_LONG }, {sys_innodb_table_locks.name, (char*) &sys_innodb_table_locks, SHOW_SYS},