MDEV-26504 THD::copy_db_to() fails to return true if THD::db is null

THD::copy_db_to(): Always return true if the output parameter
was left uninitialized. This fixes a regression that was caused
by commit 7d0d934ca642e485b2c008727dc20c83e26cce10 (MDEV-16473).

MariaDB Server 10.3 and later were unaffected by this bug
thanks to commit a7e352b54ddfaf91c92951d605cb02a4ffd2676b.

Possibly this bug only affects mysql_list_fields()
in the Embedded Server (libmysqld).

This bug was found by GCC 11.2.0 in CMAKE_BUILD_TYPE=RelWithDebInfo.
This commit is contained in:
Marko Mäkelä 2021-08-30 14:26:27 +03:00
parent fda704c82c
commit ceb40ef45b

View File

@ -4003,10 +4003,8 @@ public:
for any CTE references. for any CTE references.
*/ */
if (!lex->with_cte_resolution) if (!lex->with_cte_resolution)
{
my_message(ER_NO_DB_ERROR, ER(ER_NO_DB_ERROR), MYF(0)); my_message(ER_NO_DB_ERROR, ER(ER_NO_DB_ERROR), MYF(0));
return TRUE; return TRUE;
}
} }
else else
{ {